From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1DTP-0005rA-3v for barebox@lists.infradead.org; Mon, 10 Feb 2020 18:07:56 +0000 From: Ahmad Fatoum Date: Mon, 10 Feb 2020 19:07:50 +0100 Message-Id: <20200210180751.31108-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: [PATCH 1/2] driver: bail out, don't crash, if drv->name is not set To: barebox@lists.infradead.org Cc: Ahmad Fatoum Currently, we expect each driver to have a name. If a driver doesn't, we run into a NULL pointer dereference. Make this error scenario more pleasant by checking if a name is set and failing otherwise. The only in-tree driver affected by this is drivers/watchdog/dw_wdt.c, which will be fixed in the follow-up commit. Affected drivers can be determined with following pipeline, which should return all driver_d structure instantiations that don't contain a name: ack --A 4 'struct driver_d.*' | perl -pe 's/^--$/\n/' | \ perl -000 -ne 'print if /=.*\{.*\}/s && !/name/s' With this change, these drivers should now give a more pleasant message: ERROR: initcall dw_wdt_driver_register+0x1/0xc failed: Invalid argument Signed-off-by: Ahmad Fatoum --- drivers/base/driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/base/driver.c b/drivers/base/driver.c index eec2a2d8a2a5..116ccb25864b 100644 --- a/drivers/base/driver.c +++ b/drivers/base/driver.c @@ -308,6 +308,9 @@ int register_driver(struct driver_d *drv) { struct device_d *dev = NULL; + if (!drv->name) + return -EINVAL; + debug("register_driver: %s\n", drv->name); BUG_ON(!drv->bus); -- 2.25.0 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox