mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] arm: baltos: use compressed DTB images
@ 2020-02-17 14:38 yegorslists
  2020-02-19  7:52 ` Sascha Hauer
  0 siblings, 1 reply; 5+ messages in thread
From: yegorslists @ 2020-02-17 14:38 UTC (permalink / raw)
  To: barebox

From: Yegor Yefremov <yegorslists@googlemail.com>

This reduces the size of MLO enough to fit into SRAM.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 arch/arm/boards/vscom-baltos/lowlevel.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boards/vscom-baltos/lowlevel.c b/arch/arm/boards/vscom-baltos/lowlevel.c
index 98bbbaae1..0a220f262 100644
--- a/arch/arm/boards/vscom-baltos/lowlevel.c
+++ b/arch/arm/boards/vscom-baltos/lowlevel.c
@@ -66,7 +66,7 @@ static const struct am33xx_emif_regs ddr3_regs_256mb = {
 
 };
 
-extern char __dtb_am335x_baltos_minimal_start[];
+extern char __dtb_z_am335x_baltos_minimal_start[];
 
 /**
  * @brief The basic entry point for board initialization.
@@ -82,7 +82,7 @@ static noinline void baltos_sram_init(void)
 	uint32_t sdram_size;
 	void *fdt;
 
-	fdt = __dtb_am335x_baltos_minimal_start;
+	fdt = __dtb_z_am335x_baltos_minimal_start;
 
 	/* WDT1 is already running when the bootloader gets control
 	 * Disable it to avoid "random" resets
@@ -132,7 +132,7 @@ ENTRY_FUNCTION(start_am33xx_baltos_sdram, r0, r1, r2)
 	 */
 	__raw_writel(0x000010ff, AM33XX_PRM_RSTTIME);
 
-	fdt = __dtb_am335x_baltos_minimal_start;
+	fdt = __dtb_z_am335x_baltos_minimal_start;
 
 	fdt += get_runtime_offset();
 
-- 
2.17.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm: baltos: use compressed DTB images
  2020-02-17 14:38 [PATCH] arm: baltos: use compressed DTB images yegorslists
@ 2020-02-19  7:52 ` Sascha Hauer
  2020-02-19 15:34   ` Ahmad Fatoum
  0 siblings, 1 reply; 5+ messages in thread
From: Sascha Hauer @ 2020-02-19  7:52 UTC (permalink / raw)
  To: yegorslists; +Cc: barebox

On Mon, Feb 17, 2020 at 03:38:17PM +0100, yegorslists@googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> This reduces the size of MLO enough to fit into SRAM.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  arch/arm/boards/vscom-baltos/lowlevel.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boards/vscom-baltos/lowlevel.c b/arch/arm/boards/vscom-baltos/lowlevel.c
> index 98bbbaae1..0a220f262 100644
> --- a/arch/arm/boards/vscom-baltos/lowlevel.c
> +++ b/arch/arm/boards/vscom-baltos/lowlevel.c
> @@ -66,7 +66,7 @@ static const struct am33xx_emif_regs ddr3_regs_256mb = {
>  
>  };
>  
> -extern char __dtb_am335x_baltos_minimal_start[];
> +extern char __dtb_z_am335x_baltos_minimal_start[];
>  
>  /**
>   * @brief The basic entry point for board initialization.
> @@ -82,7 +82,7 @@ static noinline void baltos_sram_init(void)
>  	uint32_t sdram_size;
>  	void *fdt;
>  
> -	fdt = __dtb_am335x_baltos_minimal_start;
> +	fdt = __dtb_z_am335x_baltos_minimal_start;
>  
>  	/* WDT1 is already running when the bootloader gets control
>  	 * Disable it to avoid "random" resets
> @@ -132,7 +132,7 @@ ENTRY_FUNCTION(start_am33xx_baltos_sdram, r0, r1, r2)
>  	 */
>  	__raw_writel(0x000010ff, AM33XX_PRM_RSTTIME);
>  
> -	fdt = __dtb_am335x_baltos_minimal_start;
> +	fdt = __dtb_z_am335x_baltos_minimal_start;

You have to select ARM_USE_COMPRESSED_DTB from the boards Kconfig entry
to make sure the uncompressing functions are available.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm: baltos: use compressed DTB images
  2020-02-19  7:52 ` Sascha Hauer
@ 2020-02-19 15:34   ` Ahmad Fatoum
  2020-02-24 10:35     ` Yegor Yefremov
  0 siblings, 1 reply; 5+ messages in thread
From: Ahmad Fatoum @ 2020-02-19 15:34 UTC (permalink / raw)
  To: Sascha Hauer, yegorslists; +Cc: barebox

Hello Sascha,

On 2/19/20 8:52 AM, Sascha Hauer wrote:
> On Mon, Feb 17, 2020 at 03:38:17PM +0100, yegorslists@googlemail.com wrote:
>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> This reduces the size of MLO enough to fit into SRAM.
>>
>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>> ---
>>  arch/arm/boards/vscom-baltos/lowlevel.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boards/vscom-baltos/lowlevel.c b/arch/arm/boards/vscom-baltos/lowlevel.c
>> index 98bbbaae1..0a220f262 100644
>> --- a/arch/arm/boards/vscom-baltos/lowlevel.c
>> +++ b/arch/arm/boards/vscom-baltos/lowlevel.c
>> @@ -66,7 +66,7 @@ static const struct am33xx_emif_regs ddr3_regs_256mb = {
>>  
>>  };
>>  
>> -extern char __dtb_am335x_baltos_minimal_start[];
>> +extern char __dtb_z_am335x_baltos_minimal_start[];
>>  
>>  /**
>>   * @brief The basic entry point for board initialization.
>> @@ -82,7 +82,7 @@ static noinline void baltos_sram_init(void)
>>  	uint32_t sdram_size;
>>  	void *fdt;
>>  
>> -	fdt = __dtb_am335x_baltos_minimal_start;
>> +	fdt = __dtb_z_am335x_baltos_minimal_start;
>>  
>>  	/* WDT1 is already running when the bootloader gets control
>>  	 * Disable it to avoid "random" resets
>> @@ -132,7 +132,7 @@ ENTRY_FUNCTION(start_am33xx_baltos_sdram, r0, r1, r2)
>>  	 */
>>  	__raw_writel(0x000010ff, AM33XX_PRM_RSTTIME);
>>  
>> -	fdt = __dtb_am335x_baltos_minimal_start;
>> +	fdt = __dtb_z_am335x_baltos_minimal_start;
> 
> You have to select ARM_USE_COMPRESSED_DTB from the boards Kconfig entry
> to make sure the uncompressing functions are available.

ARM_USE_COMPRESSED_DTB is enabled transitively because ARCH_AM33XX
selects it.

> 
> Sascha
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm: baltos: use compressed DTB images
  2020-02-19 15:34   ` Ahmad Fatoum
@ 2020-02-24 10:35     ` Yegor Yefremov
  2020-02-25  7:47       ` Sascha Hauer
  0 siblings, 1 reply; 5+ messages in thread
From: Yegor Yefremov @ 2020-02-24 10:35 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Wed, Feb 19, 2020 at 4:34 PM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
>
> Hello Sascha,
>
> On 2/19/20 8:52 AM, Sascha Hauer wrote:
> > On Mon, Feb 17, 2020 at 03:38:17PM +0100, yegorslists@googlemail.com wrote:
> >> From: Yegor Yefremov <yegorslists@googlemail.com>
> >>
> >> This reduces the size of MLO enough to fit into SRAM.
> >>
> >> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> >> ---
> >>  arch/arm/boards/vscom-baltos/lowlevel.c | 6 +++---
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/arch/arm/boards/vscom-baltos/lowlevel.c b/arch/arm/boards/vscom-baltos/lowlevel.c
> >> index 98bbbaae1..0a220f262 100644
> >> --- a/arch/arm/boards/vscom-baltos/lowlevel.c
> >> +++ b/arch/arm/boards/vscom-baltos/lowlevel.c
> >> @@ -66,7 +66,7 @@ static const struct am33xx_emif_regs ddr3_regs_256mb = {
> >>
> >>  };
> >>
> >> -extern char __dtb_am335x_baltos_minimal_start[];
> >> +extern char __dtb_z_am335x_baltos_minimal_start[];
> >>
> >>  /**
> >>   * @brief The basic entry point for board initialization.
> >> @@ -82,7 +82,7 @@ static noinline void baltos_sram_init(void)
> >>      uint32_t sdram_size;
> >>      void *fdt;
> >>
> >> -    fdt = __dtb_am335x_baltos_minimal_start;
> >> +    fdt = __dtb_z_am335x_baltos_minimal_start;
> >>
> >>      /* WDT1 is already running when the bootloader gets control
> >>       * Disable it to avoid "random" resets
> >> @@ -132,7 +132,7 @@ ENTRY_FUNCTION(start_am33xx_baltos_sdram, r0, r1, r2)
> >>       */
> >>      __raw_writel(0x000010ff, AM33XX_PRM_RSTTIME);
> >>
> >> -    fdt = __dtb_am335x_baltos_minimal_start;
> >> +    fdt = __dtb_z_am335x_baltos_minimal_start;
> >
> > You have to select ARM_USE_COMPRESSED_DTB from the boards Kconfig entry
> > to make sure the uncompressing functions are available.
>
> ARM_USE_COMPRESSED_DTB is enabled transitively because ARCH_AM33XX
> selects it.

So, no changes required then?

Yegor

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm: baltos: use compressed DTB images
  2020-02-24 10:35     ` Yegor Yefremov
@ 2020-02-25  7:47       ` Sascha Hauer
  0 siblings, 0 replies; 5+ messages in thread
From: Sascha Hauer @ 2020-02-25  7:47 UTC (permalink / raw)
  To: Yegor Yefremov; +Cc: barebox, Ahmad Fatoum

On Mon, Feb 24, 2020 at 11:35:50AM +0100, Yegor Yefremov wrote:
> On Wed, Feb 19, 2020 at 4:34 PM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
> >
> > Hello Sascha,
> >
> > > You have to select ARM_USE_COMPRESSED_DTB from the boards Kconfig entry
> > > to make sure the uncompressing functions are available.
> >
> > ARM_USE_COMPRESSED_DTB is enabled transitively because ARCH_AM33XX
> > selects it.
> 
> So, no changes required then?

No. Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-02-25  7:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-17 14:38 [PATCH] arm: baltos: use compressed DTB images yegorslists
2020-02-19  7:52 ` Sascha Hauer
2020-02-19 15:34   ` Ahmad Fatoum
2020-02-24 10:35     ` Yegor Yefremov
2020-02-25  7:47       ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox