mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 1/3] gpiolib: use correct format specifier for ptrdiff_t
Date: Tue, 18 Feb 2020 15:16:34 +0100	[thread overview]
Message-ID: <20200218141636.6486-1-a.fatoum@pengutronix.de> (raw)

C99 specifies the 't' length modifier type for pointer difference.
barebox vsnprintf supports it, thus use it.

We are guaranteed sizeof(long) == sizeof(void *) in barebox, so this
doesn't make a difference in practice except that it silences
following GCC warning:

  ./drivers/gpio/gpiolib.c: In function 'gpioinfo_request':
  ./include/printk.h:77:43: warning: format '%ld' expects argument of
     type 'long int', but argument 3 has type 'int' [-Wformat=]
  ...
  ./barebox-stm32/drivers/gpio/gpiolib.c:89:3: note: in expansion of macro 'pr_err'
     89 |   pr_err("_gpio_request: gpio-%ld (%s) status %d\n",

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/gpio/gpiolib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index cfa77360b3d2..27674af54caa 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -86,7 +86,7 @@ static int gpioinfo_request(struct gpio_info *gi, const char *label)
 
 done:
 	if (ret)
-		pr_err("_gpio_request: gpio-%ld (%s) status %d\n",
+		pr_err("_gpio_request: gpio-%td (%s) status %d\n",
 		       gi - gpio_desc, label ? : "?", ret);
 
 	return ret;
-- 
2.25.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2020-02-18 14:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-18 14:16 Ahmad Fatoum [this message]
2020-02-18 14:16 ` [PATCH 2/3] scripts: define ALIGN(x) in scripts' <linux/kernel.h> Ahmad Fatoum
2020-02-18 14:16 ` [PATCH 3/3] scripts: imd: remove duplicate macro definitions Ahmad Fatoum
2020-02-19  7:54 ` [PATCH 1/3] gpiolib: use correct format specifier for ptrdiff_t Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200218141636.6486-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox