From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] gpiolib: use correct format specifier for ptrdiff_t
Date: Wed, 19 Feb 2020 08:54:39 +0100 [thread overview]
Message-ID: <20200219075439.zyhlnputwwjjnxyc@pengutronix.de> (raw)
In-Reply-To: <20200218141636.6486-1-a.fatoum@pengutronix.de>
On Tue, Feb 18, 2020 at 03:16:34PM +0100, Ahmad Fatoum wrote:
> C99 specifies the 't' length modifier type for pointer difference.
> barebox vsnprintf supports it, thus use it.
>
> We are guaranteed sizeof(long) == sizeof(void *) in barebox, so this
> doesn't make a difference in practice except that it silences
> following GCC warning:
>
> ./drivers/gpio/gpiolib.c: In function 'gpioinfo_request':
> ./include/printk.h:77:43: warning: format '%ld' expects argument of
> type 'long int', but argument 3 has type 'int' [-Wformat=]
> ...
> ./barebox-stm32/drivers/gpio/gpiolib.c:89:3: note: in expansion of macro 'pr_err'
> 89 | pr_err("_gpio_request: gpio-%ld (%s) status %d\n",
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/gpio/gpiolib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-02-19 7:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 14:16 Ahmad Fatoum
2020-02-18 14:16 ` [PATCH 2/3] scripts: define ALIGN(x) in scripts' <linux/kernel.h> Ahmad Fatoum
2020-02-18 14:16 ` [PATCH 3/3] scripts: imd: remove duplicate macro definitions Ahmad Fatoum
2020-02-19 7:54 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219075439.zyhlnputwwjjnxyc@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox