* [PATCH] fixup! commands: boot: create boot entries on demand
@ 2020-02-14 8:03 Ahmad Fatoum
2020-02-19 8:30 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2020-02-14 8:03 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
Don't try other boot entries if one succeeds. This is the behavior
before the change, thus reinstate it.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
commands/boot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/commands/boot.c b/commands/boot.c
index aeaba3992e1d..aaa20faae9d4 100644
--- a/commands/boot.c
+++ b/commands/boot.c
@@ -97,7 +97,7 @@ static int do_boot(int argc, char *argv[])
bootentries_for_each_entry(entries, entry) {
ret = boot_entry(entry, verbose, dryrun);
if (!ret)
- break;
+ goto out;
}
bootentries_free(entries);
--
2.25.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fixup! commands: boot: create boot entries on demand
2020-02-14 8:03 [PATCH] fixup! commands: boot: create boot entries on demand Ahmad Fatoum
@ 2020-02-19 8:30 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2020-02-19 8:30 UTC (permalink / raw)
To: Ahmad Fatoum; +Cc: barebox
On Fri, Feb 14, 2020 at 09:03:05AM +0100, Ahmad Fatoum wrote:
> Don't try other boot entries if one succeeds. This is the behavior
> before the change, thus reinstate it.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> commands/boot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I missed to apply this in time. Did that now, but I can't squash it into
the original commit anymore.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-19 8:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-14 8:03 [PATCH] fixup! commands: boot: create boot entries on demand Ahmad Fatoum
2020-02-19 8:30 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox