Re: [PATCH 0/3] Support for fastboot over UDP

[Sascha Hauer <s.hauer@pengutronix.de>]

Hi Daniel,

Nice stuff this is ;)

I gave it a try and it works well so far. We seem to have a problem
though with calling net_poll() from a poller function, see my mail to 2/3.

What I currently do not like is the limitation to only bring up UDP
fastboot during startup, it should be possible to do that during runtime
at least optionally.

Regards,
  Sascha

On Fri, Feb 28, 2020 at 09:48:20PM +0100, Daniel Glöckner wrote:
> This patch series adds support the UDP variant of the fastboot protocol
> that was already supported in its USB form by Barebox. There is also a
> TCP variant, but Barebox obviously can't support that one with its
> current network stack.
> 
> The first patch separates all functions that can be reused into a file in
> common/. Although git didn't pick up the similarities, common/fastboot.c
> can be easily diffed against the old drivers/usb/gadget/f_fastboot.c,
> especially after replacing struct f_fb with fb and struct f_fastboot with
> struct fastboot.
> 
> The global.usbgadget.fastboot_max_download_size variable has not been
> renamed because someone might expect it to have that name. But I'll
> happily drop the usbgadget part from the name if you prefer.
> 
> The generic Kconfig options have been renamed. We could add options
> with the old name that select the new options to make the transition
> easier.
> 
> The second patch contains the implementation. The code was initially
> taken from U-Boot, but had to be rewritten heavily to fit the way the
> existing Barebox fastboot code executes commands and prints messages.
> Contrary to U-Boot it does not send keep alive messages every 30
> seconds because everything is executed from a poller. The timeout of
> Google's fastboot tool is 60 seconds.
> 
> The third patch was necessary to allow network interfaces to be activated
> without sending packets. The fastboot code sends packets only in reply to
> received packets.
> 
> Daniel Glöckner (1):
>   fastboot net: workaround for receiving before sending
> 
> Edmund Henniges (2):
>   fastboot: split generic code from USB gadget
>   fastboot net: implement fastboot over UDP
> 
>  common/Kconfig                  |  35 ++
>  common/Makefile                 |   1 +
>  common/fastboot.c               | 958 +++++++++++++++++++++++++++++++
>  drivers/usb/gadget/Kconfig      |   3 +-
>  drivers/usb/gadget/f_fastboot.c | 968 ++------------------------------
>  drivers/usb/gadget/multi.c      |   5 +-
>  include/fastboot.h              |  67 +++
>  include/fastboot_net.h          |  12 +
>  include/net.h                   |   1 +
>  include/usb/fastboot.h          |  34 +-
>  include/usb/gadget-multi.h      |   2 +-
>  net/Kconfig                     |  17 +
>  net/Makefile                    |   1 +
>  net/eth.c                       |   2 +-
>  net/fastboot.c                  | 438 +++++++++++++++
>  15 files changed, 1579 insertions(+), 965 deletions(-)
>  create mode 100644 common/fastboot.c
>  create mode 100644 include/fastboot.h
>  create mode 100644 include/fastboot_net.h
>  create mode 100644 net/fastboot.c
> 
> -- 
> 2.17.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox