From: "Daniel Glöckner" <dg@emlix.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>,
Edmund Henniges <eh@emlix.com>
Subject: Re: [PATCH 05/16] Introduce slices
Date: Thu, 12 Mar 2020 00:51:54 +0100 [thread overview]
Message-ID: <20200311235154.GA28876@emlix.com> (raw)
In-Reply-To: <20200311142757.25263-6-s.hauer@pengutronix.de>
Hello Sascha,
On Wed, Mar 11, 2020 at 03:27:46PM +0100, Sascha Hauer wrote:
> +/**
> + * slice_acquired: test if a slice is acquired
> + * @slice: The slice to test
> + *
> + * This tests if a slice is acquired. Returns true if it is, false otherwise
> + */
> +bool slice_acquired(struct slice *slice)
> +{
> + struct slice_entry *se;
> + int acquired = slice->acquired;
> + bool ret = false;
> +
> + if (acquired > 0)
> + return true;
> +
> + if (acquired < 0) {
> + pr_err("Recursive dependency detected in slice %s\n",
> + slice_name(slice));
> + panic("Cannot continue");
> + }
> +
> + slice->acquired = -1;
> +
> + list_for_each_entry(se, &slice->deps, list)
> + if (slice_acquired(se->slice)) {
> + ret = true;
> + break;
> + }
> +
> + slice->acquired = acquired;
no need to restore slice->acquire from acquired since
acquired must have been zero if we reach this line.
Best regards,
Daniel
--
Dipl.-Math. Daniel Glöckner, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11,
Gothaer Platz 3, 37083 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführung: Heike Jordan, Dr. Uwe Kracke
Ust-IdNr.: DE 205 198 055
emlix - your embedded linux partner
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-03-11 23:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 14:27 [PATCH v2 00/16] Protect code from pollers Sascha Hauer
2020-03-11 14:27 ` [PATCH 01/16] net: fec_imx: Do not clear MII interrupt during receive Sascha Hauer
2020-03-11 14:27 ` [PATCH 02/16] miitool: Use mdiobus_read() Sascha Hauer
2020-03-11 14:27 ` [PATCH 03/16] net: phy: mdio-mux: Use mdiobus_read/write() Sascha Hauer
2020-03-11 14:27 ` [PATCH 04/16] net: Open ethernet devices explicitly Sascha Hauer
2020-03-11 14:27 ` [PATCH 05/16] Introduce slices Sascha Hauer
2020-03-11 23:51 ` Daniel Glöckner [this message]
2020-03-12 8:24 ` Sascha Hauer
2020-03-12 9:18 ` Daniel Glöckner
2020-03-12 10:29 ` Sascha Hauer
2020-03-11 14:27 ` [PATCH 06/16] net: Add a slice to struct eth_device Sascha Hauer
2020-03-11 14:27 ` [PATCH 07/16] net: mdiobus: Add slice Sascha Hauer
2020-03-11 14:27 ` [PATCH 08/16] usb: Add a slice to usb host controllers Sascha Hauer
2020-03-11 14:27 ` [PATCH 09/16] usbnet: Add slice Sascha Hauer
2020-03-11 14:27 ` [PATCH 10/16] net: Call net_poll() in a poller Sascha Hauer
2020-03-11 14:27 ` [PATCH 11/16] net: reply to ping requests Sascha Hauer
2020-03-11 14:27 ` [PATCH 12/16] usbnet: Be more friendly in the receive path Sascha Hauer
2020-03-11 14:27 ` [PATCH 13/16] net: phy: Also print link down messages Sascha Hauer
2020-03-11 14:27 ` [PATCH 14/16] net: ifup command: add ethernet device completion Sascha Hauer
2020-03-11 14:27 ` [PATCH 15/16] net: phy: Do not claim the link is up initially Sascha Hauer
2020-03-11 14:27 ` [PATCH 16/16] net: Add ifdown support and command Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311235154.GA28876@emlix.com \
--to=dg@emlix.com \
--cc=barebox@lists.infradead.org \
--cc=eh@emlix.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox