* [RFC] serial: ns16550: select default pinctrl state
@ 2020-03-12 20:46 Peter Mamonov
2020-03-13 9:03 ` Sascha Hauer
0 siblings, 1 reply; 3+ messages in thread
From: Peter Mamonov @ 2020-03-12 20:46 UTC (permalink / raw)
To: s.hauer; +Cc: barebox, Peter Mamonov
Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
---
drivers/serial/serial_ns16550.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/serial/serial_ns16550.c b/drivers/serial/serial_ns16550.c
index 3edeb0dcb..6b5e92c13 100644
--- a/drivers/serial/serial_ns16550.c
+++ b/drivers/serial/serial_ns16550.c
@@ -39,6 +39,7 @@
#include <malloc.h>
#include <io.h>
#include <linux/clk.h>
+#include <pinctrl.h>
#include "serial_ns16550.h"
#include <platform_data/serial-ns16550.h>
@@ -347,6 +348,8 @@ static void ns16550_probe_dt(struct device_d *dev, struct ns16550_priv *priv)
dev_err(dev, "unsupported reg-io-width (%d)\n",
width);
}
+
+ of_pinctrl_select_state_default(np);
}
static struct ns16550_drvdata ns16450_drvdata = {
--
2.20.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] serial: ns16550: select default pinctrl state
2020-03-12 20:46 [RFC] serial: ns16550: select default pinctrl state Peter Mamonov
@ 2020-03-13 9:03 ` Sascha Hauer
2020-03-13 11:27 ` Peter Mamonov
0 siblings, 1 reply; 3+ messages in thread
From: Sascha Hauer @ 2020-03-13 9:03 UTC (permalink / raw)
To: Peter Mamonov; +Cc: barebox
On Thu, Mar 12, 2020 at 11:46:07PM +0300, Peter Mamonov wrote:
> Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
> ---
> drivers/serial/serial_ns16550.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/serial/serial_ns16550.c b/drivers/serial/serial_ns16550.c
> index 3edeb0dcb..6b5e92c13 100644
> --- a/drivers/serial/serial_ns16550.c
> +++ b/drivers/serial/serial_ns16550.c
> @@ -39,6 +39,7 @@
> #include <malloc.h>
> #include <io.h>
> #include <linux/clk.h>
> +#include <pinctrl.h>
>
> #include "serial_ns16550.h"
> #include <platform_data/serial-ns16550.h>
> @@ -347,6 +348,8 @@ static void ns16550_probe_dt(struct device_d *dev, struct ns16550_priv *priv)
> dev_err(dev, "unsupported reg-io-width (%d)\n",
> width);
> }
> +
> + of_pinctrl_select_state_default(np);
Why? This should have been done by the core already at this point.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] serial: ns16550: select default pinctrl state
2020-03-13 9:03 ` Sascha Hauer
@ 2020-03-13 11:27 ` Peter Mamonov
0 siblings, 0 replies; 3+ messages in thread
From: Peter Mamonov @ 2020-03-13 11:27 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
On Fri, Mar 13, 2020 at 10:03:26AM +0100, Sascha Hauer wrote:
> On Thu, Mar 12, 2020 at 11:46:07PM +0300, Peter Mamonov wrote:
> > Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
> > ---
> > drivers/serial/serial_ns16550.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/serial/serial_ns16550.c b/drivers/serial/serial_ns16550.c
> > index 3edeb0dcb..6b5e92c13 100644
> > --- a/drivers/serial/serial_ns16550.c
> > +++ b/drivers/serial/serial_ns16550.c
> > @@ -39,6 +39,7 @@
> > #include <malloc.h>
> > #include <io.h>
> > #include <linux/clk.h>
> > +#include <pinctrl.h>
> >
> > #include "serial_ns16550.h"
> > #include <platform_data/serial-ns16550.h>
> > @@ -347,6 +348,8 @@ static void ns16550_probe_dt(struct device_d *dev, struct ns16550_priv *priv)
> > dev_err(dev, "unsupported reg-io-width (%d)\n",
> > width);
> > }
> > +
> > + of_pinctrl_select_state_default(np);
>
> Why? This should have been done by the core already at this point.
I struggled with this problem
http://lists.infradead.org/pipermail/barebox/2020-March/041206.html yesterday,
and my first guess was that pinctrl doesn't apply. So I made this patch and
didn't revert it after finding the real solution. I will do so later. Thanks
for explanation!
Peter
>
> Sascha
>
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-13 11:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-12 20:46 [RFC] serial: ns16550: select default pinctrl state Peter Mamonov
2020-03-13 9:03 ` Sascha Hauer
2020-03-13 11:27 ` Peter Mamonov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox