From: Sascha Hauer <s.hauer@pengutronix.de>
To: Peter Mamonov <pmamonov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] pinctrl-single: fix parsing of `pinctrl-single,bits` property
Date: Mon, 16 Mar 2020 12:27:53 +0100 [thread overview]
Message-ID: <20200316112752.GM3335@pengutronix.de> (raw)
In-Reply-To: <20200312203957.22867-1-pmamonov@gmail.com>
On Thu, Mar 12, 2020 at 11:39:57PM +0300, Peter Mamonov wrote:
> According to dts/Bindings/pinctrl/pinctrl-single.txt:113 the correct order of
> parameters is <offset, value, mask>.
>
> Fixes: f7e0cae43 ('pinctrl-single: Handle "pinctrl-single,function-mask" dt property')
> Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
> ---
> drivers/pinctrl/pinctrl-single.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> index d4f411b4a..2cd58df93 100644
> --- a/drivers/pinctrl/pinctrl-single.c
> +++ b/drivers/pinctrl/pinctrl-single.c
> @@ -87,8 +87,8 @@ static int pcs_set_state(struct pinctrl_device *pdev, struct device_node *np)
>
> for (i = 0; i < rows; i++) {
> offset = be32_to_cpup(mux + index++);
> - mask = be32_to_cpup(mux + index++);
> val = be32_to_cpup(mux + index++);
> + mask = be32_to_cpup(mux + index++);
> reg = pcs->read(pcs->base + offset);
> reg &= ~mask;
> reg |= val;
> --
> 2.20.1
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-03-16 11:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 20:39 [PATCH] pinctrl-single: fix parsing of `pinctrl-single, bits` property Peter Mamonov
2020-03-16 11:27 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316112752.GM3335@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=pmamonov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox