mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Michael Graichen <michael.graichen@hotmail.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH] some fixes for the zedboard build
Date: Mon, 30 Mar 2020 07:39:09 +0200	[thread overview]
Message-ID: <20200330053909.GV27288@pengutronix.de> (raw)
In-Reply-To: <DB7PR02MB43329F5FA85160DA28F68030ABCC0@DB7PR02MB4332.eurprd02.prod.outlook.com>

Hi Michael,

On Fri, Mar 27, 2020 at 09:57:11AM +0000, Michael Graichen wrote:
> Hey, 
> 
> i've attached some fixes for the zedboard build that worked, at least,
> for me.
> The MIO config in lowlevel.c seem to be very "hardware specific" but
> one can compare this to what Xilinx Vivado says.
> 
> When including the drivers for Networking, QSPI and SD one will run
> out of OCRAM very quickly that's why i commended out so much in the
> defconfig.
> 
> The changes to drivers/mci/Kconfig and drivers/mci/arasan-sdhci.c seem
> to be bug fixes.
> 
> Best regards and have a nice weekend 
> 
> Michael
> 

> diff --git a/drivers/mci/Kconfig b/drivers/mci/Kconfig
> index 80b3a2600..9f56bed3a 100644
> --- a/drivers/mci/Kconfig
> +++ b/drivers/mci/Kconfig
> @@ -141,6 +141,7 @@ config MCI_TEGRA
>  
>  config MCI_ARASAN
>  	bool "Arasan SDHCI Controller"
> +	select MCI_SDHCI
>  	help
>  	  Enable this to support SD and MMC card read/write on systems with
>  	  the Arasan SD3.0 / SDIO3.0 / eMMC4.51 host controller.

Can you make this a separate patch please?

> diff --git a/drivers/mci/arasan-sdhci.c b/drivers/mci/arasan-sdhci.c
> index b43a4f8dd..0dd9382ae 100644
> --- a/drivers/mci/arasan-sdhci.c
> +++ b/drivers/mci/arasan-sdhci.c
> @@ -278,7 +278,7 @@ static int arasan_sdhci_send_cmd(struct mci_host *mci, struct mci_cmd *cmd,
>  
>  	mask = SDHCI_INT_CMD_COMPLETE;
>  	if (data)
> -		mask |= SDHCI_INT_XFER_COMPLETE;
> +		mask |= SDHCI_INT_DATA_AVAIL;   

And this one as well. Please also add to the commit log what is going
wrong here.

I can't say much to the changes in the lowlevel code, but they should be
done as separate patches and with better commit messages.

Regards
 Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2020-03-30  5:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27  9:57 Michael Graichen
2020-03-30  5:39 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200330053909.GV27288@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=michael.graichen@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox