From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 8/8] nfs: Do not allow to abort
Date: Mon, 30 Mar 2020 11:12:10 +0200 [thread overview]
Message-ID: <20200330091210.18716-9-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20200330091210.18716-1-s.hauer@pengutronix.de>
When ctrl-c is pressed then ctrlc() will return true until
ctrlc_handled() is called. This means that once ctrl-c is pressed every
NFS operation will fail until the upper layer calls ctrlc_handled().
When for example we are doing a 'ls -l' on an NFS directory then after
a ctrl-c press not the 'ls -l' aborts, but instead the retrieving of the
directory entries which is not what we want.
Simply do not call ctrlc() in the fs layer. the NFS timeout is 2 seconds
which we have to wait until we have a chance to abort.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
fs/nfs.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/nfs.c b/fs/nfs.c
index a5fc6467fb..227a4866d7 100644
--- a/fs/nfs.c
+++ b/fs/nfs.c
@@ -450,9 +450,6 @@ again:
nfs_timer_start = get_time_ns();
while (1) {
- if (ctrlc())
- return ERR_PTR(-EINTR);
-
net_poll();
if (is_timeout(nfs_timer_start, NFS_TIMEOUT)) {
--
2.26.0.rc2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-03-30 9:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 9:12 [PATCH 0/8] NFS fixes Sascha Hauer
2020-03-30 9:12 ` [PATCH 1/8] nfs: Add function to free packets Sascha Hauer
2020-03-30 9:12 ` [PATCH 2/8] nfs: Add missing free Sascha Hauer
2020-03-30 9:12 ` [PATCH 3/8] nfs: remove unnecessary check Sascha Hauer
2020-03-30 9:12 ` [PATCH 4/8] nfs: Fix rpc_check_reply() return value for stale packets Sascha Hauer
2020-03-30 9:12 ` [PATCH 5/8] nfs: Fix polling for packets Sascha Hauer
2020-03-30 9:12 ` [PATCH 6/8] nfs: queue received packets Sascha Hauer
2020-03-30 9:12 ` [PATCH 7/8] fs: nfs: don't maintain nfs dentries in dcache Sascha Hauer
2020-03-30 9:12 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330091210.18716-9-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox