From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org, Ahmad Fatoum <ahmad@a3f.at>
Subject: Re: [PATCH 12/12] PWM: add support for STM32
Date: Tue, 31 Mar 2020 09:49:29 +0200 [thread overview]
Message-ID: <20200331074929.GJ27288@pengutronix.de> (raw)
In-Reply-To: <ff09b3f5-55f3-6347-6789-7d7f23e89d55@pengutronix.de>
On Tue, Mar 31, 2020 at 08:49:33AM +0200, Ahmad Fatoum wrote:
> Hello,
>
> On 3/31/20 8:41 AM, Sascha Hauer wrote:
> >> + pwm1 = &{/soc/timer@44000000/pwm};
> >> + pwm2 = &{/soc/timer@40000000/pwm};
> >> + pwm3 = &{/soc/timer@40001000/pwm};
> >> + pwm4 = &{/soc/timer@40002000/pwm};
> >> + pwm5 = &{/soc/timer@40003000/pwm};
> >> + pwm8 = &{/soc/timer@44001000/pwm};
> >> + pwm12 = &{/soc/timer@40006000/pwm};
> >> + pwm13 = &{/soc/timer@40007000/pwm};
> >> + pwm14 = &{/soc/timer@40008000/pwm};
> >> + pwm15 = &{/soc/timer@44006000/pwm};
> >> + pwm16 = &{/soc/timer@44007000/pwm};
> >> + pwm17 = &{/soc/timer@44008000/pwm};
> >
> > The other aliases start counting at 0. Why not the PWMs?
>
> I named them to match the SoC data sheet,
>
> The final device names are e.g. pwm12ch2, corresponding to TIM12_CH2
> in the SoC datasheet. It's IMO the best user experience, because otherwise
> you'll always have to look at the aliases in barebox to determine,
> which PWM corresponds to what's printed in the schematics.
ok.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-03-31 7:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 14:57 [PATCH 00/12] PWM: add support for ->apply, polarity and STM32 Ahmad Fatoum
2020-03-30 14:57 ` [PATCH 01/12] led: pwm: always initialize PWM LEDs as inactive Ahmad Fatoum
2020-03-30 14:57 ` [PATCH 02/12] PWM: core: remove FLAG_ENABLED Ahmad Fatoum
2020-03-30 14:57 ` [PATCH 03/12] PWM: core: remove ineffectual pwm_{set,get}_duty_cycle Ahmad Fatoum
2020-03-30 14:57 ` [PATCH 04/12] PWM: core: group PWM state into new struct pwm_state Ahmad Fatoum
2020-03-30 14:57 ` [PATCH 05/12] PWM: core: remove old PWM API in favor of Linux ->apply Ahmad Fatoum
2020-03-30 14:57 ` [PATCH 06/12] PWM: core: retire pwm_set_period Ahmad Fatoum
2020-03-30 14:57 ` [PATCH 07/12] PWM: core: apply initial state in of_pwm_request Ahmad Fatoum
2020-03-30 14:57 ` [PATCH 08/12] video: backlight-pwm: use new pwm_apply_state API Ahmad Fatoum
2020-03-31 6:10 ` Sascha Hauer
2020-03-31 6:54 ` Ahmad Fatoum
2020-03-31 7:49 ` Sascha Hauer
2020-03-30 14:57 ` [PATCH 09/12] led: pwm: " Ahmad Fatoum
2020-03-30 14:57 ` [PATCH 10/12] PWM: core: add apply API support for polarity Ahmad Fatoum
2020-03-30 14:57 ` [PATCH 11/12] of: introduce of_property_count_elems_of_size Ahmad Fatoum
2020-03-30 14:57 ` [PATCH 12/12] PWM: add support for STM32 Ahmad Fatoum
2020-03-31 6:41 ` Sascha Hauer
2020-03-31 6:49 ` Ahmad Fatoum
2020-03-31 7:49 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200331074929.GJ27288@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=ahmad@a3f.at \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox