From: Antony Pavlov <antonynpavlov@gmail.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] startup: introduce global.endianity variable
Date: Mon, 6 Apr 2020 15:12:27 +0300 [thread overview]
Message-ID: <20200406151227.62a4bd5c928c46415638876c@gmail.com> (raw)
In-Reply-To: <8b4ce6ee-b978-1cc8-956c-ce6e1b5f7e35@pengutronix.de>
On Fri, 3 Apr 2020 14:39:27 +0200
Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
Hi Ahmad,
You are right! There are several mentions of "endianness"
in current barebox codebase and there is no "endianity" mention.
I'll resend fixed patch soon.
--
Best regards,
Antony Pavlov
> Hi,
>
> On 4/3/20 2:26 PM, Antony Pavlov wrote:
> > The global.endianity variable make it possible
>
> I'd prefer you call it endianness, as that's the term we are
> using elsewhere in barebox.
>
> (unless you've a good reason to introduce a new name,
> if so that should be part of the commit message)
>
> Cheers
> Ahmad
>
> > to determine current endian mode from command
> > line or from script on bi-endian capable system.
> >
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > ---
> > common/globalvar.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/common/globalvar.c b/common/globalvar.c
> > index c87f2c9339..7632cb6418 100644
> > --- a/common/globalvar.c
> > +++ b/common/globalvar.c
> > @@ -591,6 +591,8 @@ int globalvar_add_simple_ip(const char *name, IPaddr_t *ip)
> >
> > static int globalvar_init(void)
> > {
> > + const char *endianity;
> > +
> > register_device(&global_device);
> >
> > if (IS_ENABLED(CONFIG_NVVAR))
> > @@ -598,11 +600,19 @@ static int globalvar_init(void)
> >
> > globalvar_add_simple("version", UTS_RELEASE);
> >
> > + if (IS_ENABLED(CONFIG_CPU_BIG_ENDIAN))
> > + endianity = "big";
> > + else
> > + endianity = "little";
> > +
> > + globalvar_add_simple("endianity", endianity);
> > +
> > return 0;
> > }
> > pure_initcall(globalvar_init);
> >
> > BAREBOX_MAGICVAR_NAMED(global_version, global.version, "The barebox version");
> > +BAREBOX_MAGICVAR_NAMED(global_endianity, global.endianity, "The barebox endianity");
> >
> > /**
> > * nvvar_save - save NV variables to persistent environment
> >
>
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-04-06 12:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 12:26 Antony Pavlov
2020-04-03 12:39 ` Ahmad Fatoum
2020-04-06 12:12 ` Antony Pavlov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406151227.62a4bd5c928c46415638876c@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox