mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 3/3] driver: Call of_clk_set_defaults for each probed device
Date: Tue, 14 Apr 2020 12:02:00 +0200	[thread overview]
Message-ID: <20200414100200.GG27288@pengutronix.de> (raw)
In-Reply-To: <0755ee61-3cd4-3e42-8d9c-cd57eb615ce6@pengutronix.de>

On Mon, Apr 06, 2020 at 08:01:19AM +0200, Ahmad Fatoum wrote:
> Hello Sascha,
> 
> On 2/13/20 11:58 AM, Sascha Hauer wrote:
> > So far we only honour the assigned-clocks and assigned-clock-rates
> > device tree properties for the clock controller nodes. With this patch
> > we also honour the properties for each device which is done by Linux
> > as well.
> 
> This breaks the default barebox console on the i.MX7 sabresd.
> The default UART, uart1, specifies assigned-clock-parents, which is now applied
> and causes garbage to be output on the serial port.
> 
> &uart1 {
>        /delete-property/ assigned-clocks;
>        /delete-property/ assigned-clock-parents;
> };
> 
> Fixes it, but I didn't dig deeper than that.

Care to send this as a patch so that we at least have a stop gap
solution?

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2020-04-14 10:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13 10:58 [PATCH 1/3] clk-conf.h: Add missing re-inclusion protection Sascha Hauer
2020-02-13 10:58 ` [PATCH 2/3] clk-conf.h: Add static inline wrapper for of_clk_set_defaults() Sascha Hauer
2020-02-13 10:58 ` [PATCH 3/3] driver: Call of_clk_set_defaults for each probed device Sascha Hauer
2020-04-06  6:01   ` Ahmad Fatoum
2020-04-14 10:02     ` Sascha Hauer [this message]
2020-04-15  9:57       ` Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200414100200.GG27288@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox