From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 4/5] spi: Add fsl-dspi driver
Date: Tue, 14 Apr 2020 12:30:08 +0200 [thread overview]
Message-ID: <20200414103008.GJ27288@pengutronix.de> (raw)
In-Reply-To: <CAHQ1cqHYd47QGKGg9NvTQZpa1bYz1bZaFyoSSa5JJ+diuMA=iA@mail.gmail.com>
On Sat, Apr 04, 2020 at 12:14:33PM -0700, Andrey Smirnov wrote:
> On Wed, Mar 25, 2020 at 1:36 AM Sascha Hauer <s.hauer@pengutronix.de> wrote:
> >
> > The fsl-dspi is found on Freescale Vybrid, Coldfire and Layerscape SoCs.
> > This adds the driver based on the Linux driver as of v5.5. Coldfire
> > support has been dropped as it's rather obsolete. Vybrid support has
> > been dropped because it needs the DMA engine support we do not have in
> > barebox. What's left is support for Layerscape where this driver has
> > been tested on.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> > drivers/spi/Kconfig | 7 +
> > drivers/spi/Makefile | 1 +
> > drivers/spi/spi-fsl-dspi.c | 655 +++++++++++++++++++++++++++++++++++++
> > 3 files changed, 663 insertions(+)
> > create mode 100644 drivers/spi/spi-fsl-dspi.c
> >
> > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> > index 3758a0fad9..96235a1be2 100644
> > --- a/drivers/spi/Kconfig
> > +++ b/drivers/spi/Kconfig
> > @@ -44,6 +44,13 @@ config DRIVER_SPI_FSL_QUADSPI
> > This controller does not support generic SPI messages. It only
> > supports the high-level SPI memory interface.
> >
> > +config SPI_FSL_DSPI
> > + bool "Freescale DSPI controller"
> > + depends on ARCH_LAYERSCAPE
> > + help
> > + This enables support for the Freescale DSPI controller in master
> > + mode. VF610, LS1021A and ColdFire platforms uses the controller.
>
> Sorry I didn't notice this patch earlier. Maybe we should drop the
> wording about VF610 here since there a separate DSPI driver for Vybrid
> as well: https://git.pengutronix.de/cgit/barebox/tree/drivers/spi/Kconfig?h=next#n90
So there already is a driver for this hardware in barebox. I missed that :(
I dropped the wording about VF610 for now, but the real solution should
be to use the existing driver or at least merge them. I'll see when and
if I can find time for this.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-04-14 10:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 8:36 [PATCH 0/5] Add fsl-dspi driver support Sascha Hauer
2020-03-25 8:36 ` [PATCH 1/5] regmap-mmio: Add missing pieces for 64bit support Sascha Hauer
2020-03-25 8:36 ` [PATCH 2/5] regmap-mmio: Add big endian support Sascha Hauer
2020-03-25 8:36 ` [PATCH 3/5] spi: validate spi messages Sascha Hauer
2020-03-25 8:36 ` [PATCH 4/5] spi: Add fsl-dspi driver Sascha Hauer
2020-04-04 19:14 ` Andrey Smirnov
2020-04-14 10:30 ` Sascha Hauer [this message]
2020-03-25 8:36 ` [PATCH 5/5] mtd: spi-nor: Add support for cy15x104q Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414103008.GJ27288@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox