From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSxtv-00073x-73 for barebox@lists.infradead.org; Mon, 27 Apr 2020 07:10:03 +0000 Date: Mon, 27 Apr 2020 09:09:56 +0200 From: Sascha Hauer Message-ID: <20200427070956.GK5877@pengutronix.de> References: <20200421211545.32353-1-u.kleine-koenig@pengutronix.de> <20200421211545.32353-2-u.kleine-koenig@pengutronix.de> <20200423081324.tzfe67tx4ah7krnm@pengutronix.de> <20200423101631.rwqopetiy52nr77r@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200423101631.rwqopetiy52nr77r@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v2 2/2] commands/*: Replace license and copyright boilerplate by SPDX identfiers To: Uwe =?iso-8859-15?Q?Kleine-K=F6nig?= Cc: barebox@lists.infradead.org, Ahmad Fatoum , Roland Hieber On Thu, Apr 23, 2020 at 12:16:31PM +0200, Uwe Kleine-K=F6nig wrote: > Hello Roland, > = > On Thu, Apr 23, 2020 at 10:13:24AM +0200, Roland Hieber wrote: > > It's already applied now, but for the future, such large patches are > > really easier to review when they do only one thing at a time (replacing > > the boilerplate with license identifiers, changing copyright tags, > > changing old to new identifiers, adding new identifiers etc.). > > = > > That that, I couldn't find any errors, but that doesn't mean there > > aren't any. :) > = > That's one side of the coin. The other is that several patches touching > all the same area result in more work to create the patches and make > patch and commit handling more complicated. While I agree in general > that one-patch-does-one-thing is a good concept I think for > rearrangements like this fixing all files in a directory in one go is > fine. Otherwise the result are patches that just add empty lines before > comments which IMHO doens't justify a patch. Doing this en passant is > fine however. > = > Sascha, what's your position here? Well one-patch-does-one-thing is nice and important for me when doing code changes, but in this case I think reviewing the patch is sufficiently easy, splitting it up is unnecessary work. Sascha -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox