From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org, "Roland Hieber" <rhi@pengutronix.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] treewide: remove references to CREDITS
Date: Tue, 28 Apr 2020 09:41:01 +0200 [thread overview]
Message-ID: <20200428074101.GV5877@pengutronix.de> (raw)
In-Reply-To: <96b74c98-191f-d485-a531-1decab805dfc@pengutronix.de>
On Tue, Apr 28, 2020 at 09:31:25AM +0200, Ahmad Fatoum wrote:
> Hi,
>
> On 4/23/20 10:44 PM, Uwe Kleine-König wrote:
> > The CREDITS file was removed from barebox in 2015 by commit 6570288f2d97
> > ("Remove the CREDITS file"). Remove references to it from several files.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
>
> > diff --git a/include/menu.h b/include/menu.h
> > index 77c496c65c17..52575f7454b1 100644
> > --- a/include/menu.h
> > +++ b/include/menu.h
> > @@ -2,9 +2,6 @@
> > /*
> > * (C) Copyright 2009-2010 Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > *
> > - * See file CREDITS for list of people who contributed to this
> > - * project.
> > - */
>
> You break the comment here,
My compile test found that as well, I already fixed it up.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-04-28 7:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 20:44 Uwe Kleine-König
2020-04-24 9:31 ` Roland Hieber
2020-04-27 6:58 ` Sascha Hauer
2020-04-28 7:31 ` Ahmad Fatoum
2020-04-28 7:41 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428074101.GV5877@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=rhi@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox