[PATCH 1/5] commands: remove left-over CMD_AT91MUX Kconfig option

[PATCH 1/5] commands: remove left-over CMD_AT91MUX Kconfig option

[Ahmad Fatoum]

71ff9bfebd ("pinctrl: at91: add pinctrl driver") removed the
implementation of the command, but left the now useless config option.
Remove it.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 commands/Kconfig | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/commands/Kconfig b/commands/Kconfig
index 77637f916c16..8de98ef3ee8e 100644
--- a/commands/Kconfig
+++ b/commands/Kconfig
@@ -28,22 +28,6 @@ config CMD_AT91CLK
 	help
 	  List clock configuration.
 
-config CMD_AT91MUX
-	bool "at91mux"
-	default y
-	depends on ARCH_AT91
-	help
-	  List MUX configuration
-
-	  Usage: at91mux [-pb]
-
-	  Dump current MUX configuration. If a BANK or PIN has been
-	  specified dump pin details.
-
-	  Options:
-	  -p PIN   pin number
-	  -b BANK  bank number
-
 config CMD_ARM_CPUINFO
 	bool "cpuinfo command"
 	default y
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 2/5] x86: mach-i386: remove unused X86_GENERIC_HAS_{ISA, PCI, USB} options

[Ahmad Fatoum]

Out of the four options in the file, only X86_GENERIC_HAS_VIDEO is used.
The others have been without backing code for 10 years, so drop them.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 arch/x86/mach-i386/Kconfig | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/arch/x86/mach-i386/Kconfig b/arch/x86/mach-i386/Kconfig
index b64d21fd9aa3..2d0bfb475947 100644
--- a/arch/x86/mach-i386/Kconfig
+++ b/arch/x86/mach-i386/Kconfig
@@ -3,26 +3,11 @@ menu "Board specific settings"
 
 if X86_BOOTLOADER
 
-config X86_GENERIC_HAS_ISA
-	bool "ISA support"
-	help
-	  Say Y here if the target supports a ISA bus
-
-config X86_GENERIC_HAS_PCI
-	bool "PCI support"
-	help
-	  Say Y here if the target supports a PCI bus
-
 config X86_GENERIC_HAS_VIDEO
 	bool "video support"
 	help
 	  Say Y here if the target supports a video output
 
-config X86_GENERIC_HAS_USB
-	bool "USB support"
-	help
-	  Say Y here if the target supports a USB interface
-
 endif
 
 endmenu
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 3/5] net: remove unused Kconfig options

[Ahmad Fatoum]

Both options are used nowhere and can be dropped:

- OF_NET code is compiled always and code is discarded at link-time if
  unreferenced
- Designware Ethernet can be enabled in Kconfig and no arch code
  selects the symbol

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 drivers/net/Kconfig | 3 ---
 drivers/of/Kconfig  | 4 ----
 2 files changed, 7 deletions(-)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 5823320b03f1..efa16b30e40e 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -7,9 +7,6 @@ config HAS_AT91_ETHER
 config HAS_CS8900
 	bool
 
-config HAS_DESIGNWARE_ETH
-	bool
-
 config HAS_DM9000
 	bool
 
diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
index 9ed86afd748c..23be25d85d09 100644
--- a/drivers/of/Kconfig
+++ b/drivers/of/Kconfig
@@ -18,10 +18,6 @@ config OFDEVICE
 config OF_ADDRESS_PCI
 	bool
 
-config OF_NET
-	depends on NET
-	def_bool y
-
 config OF_GPIO
 	depends on GPIOLIB
 	depends on OFDEVICE
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 4/5] net: enc28j60: fix typo in referenced Kconfig option

[Ahmad Fatoum]

There is no ENC28J60_WRITEVERIFY, instead the Kconfig file defines
DRIVER_NET_ENC28J60_WRITEVERIFY. This has been this way since the very
first commit adding the driver.

The option is off by default, so this shouldn't break anything that
didn't mess with the option. Fix the typo.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 drivers/net/enc28j60.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/enc28j60.c b/drivers/net/enc28j60.c
index 3628a88f7dd3..b3cfb65c1c2e 100644
--- a/drivers/net/enc28j60.c
+++ b/drivers/net/enc28j60.c
@@ -273,7 +273,7 @@ static void enc28j60_mem_read(struct enc28j60_net *priv,
 {
 	enc28j60_regw_write(priv, ERDPTL, addr);
 
-	if (IS_ENABLED(CONFIG_ENC28J60_WRITEVERIFY)) {
+	if (IS_ENABLED(CONFIG_DRIVER_NET_ENC28J60_WRITEVERIFY)) {
 		u16 reg;
 		reg = enc28j60_regw_read(priv, ERDPTL);
 		if (reg != addr)
@@ -293,7 +293,7 @@ enc28j60_packet_write(struct enc28j60_net *priv, int len, const u8 *data)
 	/* Set the write pointer to start of transmit buffer area */
 	enc28j60_regw_write(priv, EWRPTL, TXSTART_INIT);
 
-	if (IS_ENABLED(CONFIG_ENC28J60_WRITEVERIFY)) {
+	if (IS_ENABLED(CONFIG_DRIVER_NET_ENC28J60_WRITEVERIFY)) {
 		u16 reg;
 		reg = enc28j60_regw_read(priv, EWRPTL);
 		if (reg != TXSTART_INIT)
@@ -710,7 +710,7 @@ static int enc28j60_eth_send(struct eth_device *edev, void *packet,
 	enc28j60_packet_write(priv, packet_length, packet);
 
 	/* readback and verify written data */
-	if (IS_ENABLED(CONFIG_ENC28J60_WRITEVERIFY)) {
+	if (IS_ENABLED(CONFIG_DRIVER_NET_ENC28J60_WRITEVERIFY)) {
 		int test_len, k;
 		u8 test_buf[64]; /* limit the test to the first 64 bytes */
 		int okflag;
@@ -808,7 +808,7 @@ static void enc28j60_hw_rx(struct eth_device *edev)
 
 	enc28j60_regw_write(priv, ERXRDPTL, erxrdpt);
 
-	if (IS_ENABLED(CONFIG_ENC28J60_WRITEVERIFY)) {
+	if (IS_ENABLED(CONFIG_DRIVER_NET_ENC28J60_WRITEVERIFY)) {
 		u16 reg;
 		reg = enc28j60_regw_read(priv, ERXRDPTL);
 		if (reg != erxrdpt)
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 5/5] PPC: remove unused left-over Kconfig option

[Ahmad Fatoum]

5e50ab4f ("pcm030: cleanup config.h") removed the last reference to
MACH_PHYCORE_MPC5200B_TINY_REV_1 (The current name is a typo), so the
Kconfig option hasn't been serving a purpose for 7 years.  Drop it.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 arch/ppc/mach-mpc5xxx/Kconfig | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/arch/ppc/mach-mpc5xxx/Kconfig b/arch/ppc/mach-mpc5xxx/Kconfig
index 180aa32ad12e..4da947dc6cfc 100644
--- a/arch/ppc/mach-mpc5xxx/Kconfig
+++ b/arch/ppc/mach-mpc5xxx/Kconfig
@@ -34,17 +34,4 @@ config MPC5xxx
 	depends on MACH_PHYCORE_MPC5200B_TINY
 	default y
 
-menu "Board specific settings"
-
-config MACH_PHYCORE_MPC5200B_TINY_REV
-	int "Board Revision"
-	default 1
-	depends on MACH_PHYCORE_MPC5200B_TINY
-	help
-	  Revision 0 and revision 1 of the tiny board have
-	  incompatible flash settings. Unless you have a very
-	  old board you should set this option to 1
-
-endmenu
-
 endif
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 1/5] commands: remove left-over CMD_AT91MUX Kconfig option

[Sascha Hauer]

On Wed, Apr 29, 2020 at 07:39:10AM +0200, Ahmad Fatoum wrote:
> 71ff9bfebd ("pinctrl: at91: add pinctrl driver") removed the
> implementation of the command, but left the now useless config option.
> Remove it.
> 
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
>  commands/Kconfig | 16 ----------------
>  1 file changed, 16 deletions(-)

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox