From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTgOh-0002se-72 for barebox@lists.infradead.org; Wed, 29 Apr 2020 06:40:44 +0000 From: Ahmad Fatoum Date: Wed, 29 Apr 2020 08:40:39 +0200 Message-Id: <20200429064040.5845-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: [PATCH 1/2] scripts: imd: fix uninitialized variable read To: barebox@lists.infradead.org Cc: Ahmad Fatoum Errors are propagated in the loop and ret is never set. Remove it. Signed-off-by: Ahmad Fatoum --- scripts/bareboximd.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/scripts/bareboximd.c b/scripts/bareboximd.c index b733cae61c87..d11b661fa391 100644 --- a/scripts/bareboximd.c +++ b/scripts/bareboximd.c @@ -53,7 +53,7 @@ int imd_command_setenv(const char *variable_name, const char *value) static int write_file(const char *filename, const void *buf, size_t size) { - int fd, ret; + int fd; int now; fd = open(filename, O_WRONLY | O_TRUNC | O_CREAT, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); @@ -74,9 +74,6 @@ static int write_file(const char *filename, const void *buf, size_t size) close(fd); - if (ret < 0) - return ret; - return 0; } -- 2.26.2 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox