From: Sascha Hauer <s.hauer@pengutronix.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/5] ppc: pass -mno-spe and -mspe=no to cc-option
Date: Mon, 4 May 2020 08:36:43 +0200 [thread overview]
Message-ID: <20200504063643.GK5877@pengutronix.de> (raw)
In-Reply-To: <20200429173419.681074-3-masahiroy@kernel.org>
On Thu, Apr 30, 2020 at 02:34:16AM +0900, Masahiro Yamada wrote:
> My compiler does not understand -mno-spe or -msped=n.
>
> powerpc-linux-gcc: error: unrecognized command line option '-mno-spe'; did you mean '-fno-see'?
> powerpc-linux-gcc: error: unrecognized command line option '-mspe=no'
>
> Pass them to cc-option becasue this is what Linux does.
>
> Also, assign the compiler flags to CFLAGS, AFLAGS, and CPPFLAGS properly.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
I skipped this one as I have a similar patch in the tree already. We
might need a fixup patch to move -m32 to KBUILD_AFLAGS.
Sascha
>
> arch/ppc/Makefile | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/arch/ppc/Makefile b/arch/ppc/Makefile
> index 276b1f6bf..3d8ddf377 100644
> --- a/arch/ppc/Makefile
> +++ b/arch/ppc/Makefile
> @@ -1,8 +1,10 @@
> KBUILD_DEFCONFIG := p2020rdb_defconfig
>
> -KBUILD_CPPFLAGS += -ffixed-r14 -m32 \
> - -meabi -D __PPC__ \
> - -fno-strict-aliasing -mno-spe -mspe=no
> +KBUILD_CFLAGS += -ffixed-r14 -m32 -meabi -fno-strict-aliasing
> +KBUILD_CFLAGS += $(call cc-option,-mno-spe)
> +KBUILD_CFLAGS += $(call cc-option,-mspe=no)
> +KBUILD_AFLAGS += -m32
> +KBUILD_CPPFLAGS += -D __PPC__
>
> ifdef CONFIG_RELOCATABLE
> KBUILD_CPPFLAGS += -fPIC -mrelocatable
> --
> 2.25.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-05-04 6:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 17:34 [PATCH 0/5] move arch/ppc to arch/powerpc Masahiro Yamada
2020-04-29 17:34 ` [PATCH 1/5] ppc: remove unneeded -D CONFIG_PPC Masahiro Yamada
2020-04-29 17:34 ` [PATCH 2/5] ppc: pass -mno-spe and -mspe=no to cc-option Masahiro Yamada
2020-05-04 6:36 ` Sascha Hauer [this message]
2020-04-29 17:34 ` [PATCH 3/5] ppc: add arch/ppc/Kbuild Masahiro Yamada
2020-04-29 17:34 ` [PATCH 4/5] image: support 'powerpc' for mkimage architecture Masahiro Yamada
2020-04-29 17:34 ` [PATCH 5/5] ppc: rename arch/ppc/ to arch/powerpc/ Masahiro Yamada
2020-05-04 6:37 ` [PATCH 0/5] move arch/ppc to arch/powerpc Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504063643.GK5877@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox