From: Sascha Hauer <s.hauer@pengutronix.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] mips: remove unused INCDIR and BOARD variables in Makefile
Date: Mon, 4 May 2020 08:49:03 +0200 [thread overview]
Message-ID: <20200504064903.GO5877@pengutronix.de> (raw)
In-Reply-To: <20200430044449.762595-1-masahiroy@kernel.org>
On Thu, Apr 30, 2020 at 01:44:48PM +0900, Masahiro Yamada wrote:
> The variable INCDIR is not used by anyone.
>
> The variable BOARD is not set by anyone, so $(BOARD) is always empty.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
Applied, thanks
Sascha
>
> arch/mips/Makefile | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index 4717f49a4..abfa82504 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -88,25 +88,12 @@ else
> KBUILD_CPPFLAGS += $(patsubst %,-I$(srctree)/%include,$(machdirs))
> endif
>
> -ifeq ($(incdir-y),)
> -incdir-y := $(machine-y)
> -endif
> -INCDIR := arch-$(incdir-y)
> -
> -ifeq ($(KBUILD_SRC),)
> -KBUILD_CPPFLAGS += -I$(BOARD)/include
> -else
> -KBUILD_CPPFLAGS += -I$(srctree)/$(BOARD)/include
> -endif
> -
> ifneq ($(machine-y),)
> MACH := arch/mips/mach-$(machine-y)/
> else
> MACH :=
> endif
>
> -common-y += $(BOARD)
> -
> common-y += $(MACH)
> common-y += arch/mips/lib/
> common-y += arch/mips/boot/
> --
> 2.25.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-05-04 6:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 4:44 Masahiro Yamada
2020-04-30 4:44 ` [PATCH 2/2] mips: remove unused board/debug_ll.h Masahiro Yamada
2020-05-04 6:49 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504064903.GO5877@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox