From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVqUG-0006wg-IJ for barebox@lists.infradead.org; Tue, 05 May 2020 05:51:26 +0000 Date: Tue, 5 May 2020 07:51:19 +0200 From: Sascha Hauer Message-ID: <20200505055119.GX5877@pengutronix.de> References: <20200504083542.4095-1-s.trumtrar@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200504083542.4095-1-s.trumtrar@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/2] scripts: bareboximd: fix write_file error handling To: Steffen Trumtrar Cc: Barebox List On Mon, May 04, 2020 at 10:35:41AM +0200, Steffen Trumtrar wrote: > write will never return 0 on POSIX conformant systems. Remove this error > path. > Also, close the file on error. > > Signed-off-by: Steffen Trumtrar > --- > scripts/bareboximd.c | 17 ++++++----------- > 1 file changed, 6 insertions(+), 11 deletions(-) Applied, thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox