[PATCH 1/2] video: backlight-pwm: remove unused struct member

[PATCH 1/2] video: backlight-pwm: remove unused struct member

[Ahmad Fatoum]

pwm_backlight.max_value is unused anywhere. Drop it.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 drivers/video/backlight-pwm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/video/backlight-pwm.c b/drivers/video/backlight-pwm.c
index c2979f914de8..fda23b8243f6 100644
--- a/drivers/video/backlight-pwm.c
+++ b/drivers/video/backlight-pwm.c
@@ -34,7 +34,6 @@ struct pwm_backlight {
 	unsigned int *levels;
 	int enable_gpio;
 	int enable_active_high;
-	int max_value;
 	int enabled;
 	unsigned int scale;
 };
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 2/2] video: backlight-pwm: set backlight dev.parent to hardware dev

[Ahmad Fatoum]

backlight_register allocates a new backlight device. Populating the
device's parent field with the hardware device gives us more
informational devinfo output.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 drivers/video/backlight-pwm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/video/backlight-pwm.c b/drivers/video/backlight-pwm.c
index fda23b8243f6..cae016be8f3d 100644
--- a/drivers/video/backlight-pwm.c
+++ b/drivers/video/backlight-pwm.c
@@ -202,6 +202,7 @@ static int backlight_pwm_of_probe(struct device_d *dev)
 
 	pwm_backlight->backlight.slew_time_ms = 100;
 	pwm_backlight->backlight.brightness_set = backlight_pwm_set;
+	pwm_backlight->backlight.dev.parent = dev;
 	pwm_backlight->backlight.node = dev->device_node;
 
 	ret = backlight_register(&pwm_backlight->backlight);
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 1/2] video: backlight-pwm: remove unused struct member

[Sascha Hauer]

On Mon, May 11, 2020 at 09:42:19AM +0200, Ahmad Fatoum wrote:
> pwm_backlight.max_value is unused anywhere. Drop it.
> 
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
>  drivers/video/backlight-pwm.c | 1 -
>  1 file changed, 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/video/backlight-pwm.c b/drivers/video/backlight-pwm.c
> index c2979f914de8..fda23b8243f6 100644
> --- a/drivers/video/backlight-pwm.c
> +++ b/drivers/video/backlight-pwm.c
> @@ -34,7 +34,6 @@ struct pwm_backlight {
>  	unsigned int *levels;
>  	int enable_gpio;
>  	int enable_active_high;
> -	int max_value;
>  	int enabled;
>  	unsigned int scale;
>  };
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox