From: Masahiro Yamada <masahiroy@kernel.org>
To: barebox@lists.infradead.org
Cc: Masahiro Yamada <masahiroy@kernel.org>
Subject: [PATCH 2/2] kbuild: build modules by 'make'
Date: Tue, 19 May 2020 02:54:58 +0900 [thread overview]
Message-ID: <20200518175458.178943-2-masahiroy@kernel.org> (raw)
In-Reply-To: <20200518175458.178943-1-masahiroy@kernel.org>
In Linux, 'make' and 'make all' work equivalently; it builds both
vmlinux and modules.
In barebox, strangely, 'make all' builds both barebox and modules,
but 'make' builds only barebox because KBUILD_MODULES is unset.
The check for 'ifeq ($(MAKECMDGOALS),)' is missing since the day-one.
Fixes: b02e0966412c ("add additional linking stage for modules")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
Makefile | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Makefile b/Makefile
index d477494d6..9f30fafdd 100644
--- a/Makefile
+++ b/Makefile
@@ -533,6 +533,10 @@ ifneq ($(filter all _all modules,$(MAKECMDGOALS)),)
KBUILD_MODULES := 1
endif
+ifeq ($(MAKECMDGOALS),)
+ KBUILD_MODULES := 1
+endif
+
export KBUILD_MODULES KBUILD_BUILTIN
ifdef need-config
--
2.25.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-05-18 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 17:54 [PATCH 1/2] kconfig: add 'option modules' to allow tristate options to become m Masahiro Yamada
2020-05-18 17:54 ` Masahiro Yamada [this message]
2020-05-18 18:24 ` Masahiro Yamada
2020-05-20 11:09 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518175458.178943-2-masahiroy@kernel.org \
--to=masahiroy@kernel.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox