Re: [PATCH v2 09/10] fastboot net: implement fastboot over UDP

[Sascha Hauer <s.hauer@pengutronix.de>]

On Thu, May 14, 2020 at 08:21:57PM +0200, Daniel Glöckner wrote:
> From: Edmund Henniges <eh@emlix.com>
> 
> This implements the UDP variant of the fastboot protocol. The only way to
> start the service for now is to compile with CONFIG_FASTBOOT_NET_ON_BOOT.
> The service will bind to the network interface that provides the IPv4
> gateway.
> 
> Sending an OKAY packet before performing a restart is necessary since
> contrary to USB the host will not notice when a UDP server disappears.
> 
> Signed-off-by: Edmund Henniges <eh@emlix.com>
> Signed-off-by: Daniel Glöckner <dg@emlix.com>
> ---
> +
> +#ifdef CONFIG_FASTBOOT_NET_ON_BOOT
> +static struct fastboot_net *fastboot_net_obj;
> +
> +static int fastboot_on_boot(void)
> +{
> +	struct fastboot_net *fbn;
> +
> +	ifup_all(0);
> +	fbn = fastboot_net_init(NULL);
> +
> +	if (IS_ERR(fbn))
> +		return PTR_ERR(fbn);
> +
> +	fastboot_net_obj = fbn;
> +	return 0;
> +}
> +
> +static void fastboot_net_exit(void)
> +{
> +	if (fastboot_net_obj)
> +		fastboot_net_free(fastboot_net_obj);
> +}

fastboot_net_obj won't be NULL here, the check should be if(!IS_ERR())
instead.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox