mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] kbuild: add -std=gnu89 to KBUILD_CFLAGS
@ 2020-05-18 14:56 Masahiro Yamada
  2020-05-20 11:06 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2020-05-18 14:56 UTC (permalink / raw)
  To: barebox; +Cc: Masahiro Yamada

Barebox imports lots of code from Linux, so should use the same
language standard as Linux.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 7a620b504..d477494d6 100644
--- a/Makefile
+++ b/Makefile
@@ -416,7 +416,7 @@ KBUILD_CPPFLAGS        := -D__KERNEL__ -D__BAREBOX__ $(LINUXINCLUDE) -fno-builti
 KBUILD_CFLAGS   := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
 		   -fno-strict-aliasing -fno-common \
                    -Werror=implicit-function-declaration -Werror=implicit-int \
-                   -Os -pipe -Wmissing-prototypes
+                   -Os -pipe -Wmissing-prototypes -std=gnu89
 KBUILD_AFLAGS          := -D__ASSEMBLY__
 
 LDFLAGS_barebox	:= -Map barebox.map
-- 
2.25.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] kbuild: add -std=gnu89 to KBUILD_CFLAGS
  2020-05-18 14:56 [PATCH] kbuild: add -std=gnu89 to KBUILD_CFLAGS Masahiro Yamada
@ 2020-05-20 11:06 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2020-05-20 11:06 UTC (permalink / raw)
  To: Masahiro Yamada; +Cc: barebox

On Mon, May 18, 2020 at 11:56:00PM +0900, Masahiro Yamada wrote:
> Barebox imports lots of code from Linux, so should use the same
> language standard as Linux.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/Makefile b/Makefile
> index 7a620b504..d477494d6 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -416,7 +416,7 @@ KBUILD_CPPFLAGS        := -D__KERNEL__ -D__BAREBOX__ $(LINUXINCLUDE) -fno-builti
>  KBUILD_CFLAGS   := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
>  		   -fno-strict-aliasing -fno-common \
>                     -Werror=implicit-function-declaration -Werror=implicit-int \
> -                   -Os -pipe -Wmissing-prototypes
> +                   -Os -pipe -Wmissing-prototypes -std=gnu89
>  KBUILD_AFLAGS          := -D__ASSEMBLY__
>  
>  LDFLAGS_barebox	:= -Map barebox.map
> -- 
> 2.25.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-20 11:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-18 14:56 [PATCH] kbuild: add -std=gnu89 to KBUILD_CFLAGS Masahiro Yamada
2020-05-20 11:06 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox