Re: [PATCH] pwm: Replace license and copyright boilerplate by SPDX identfiers

[Roland Hieber <rhi@pengutronix.de>]

On Wed, May 20, 2020 at 02:10:47PM +0200, Ahmad Fatoum wrote:
> Hello,
> 
> On 5/19/20 6:52 PM, Uwe Kleine-König wrote:
> > This adapts all files that were identifed by licensecheck
> > (https://salsa.debian.org/build-common-team/licensecheck.git) as
> > licensed under the GPL and that have a (IMHO) clear copyright statement.
> > 
> > The advantage is that these specifiers are machine-parseable which helps
> > license conformance, e.g. for packaging barebox in Debian.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> >  drivers/pwm/core.c    | 15 +++------------
> >  drivers/pwm/pwm-mxs.c | 12 ++----------
> >  drivers/pwm/pxa_pwm.c |  6 ++----
> >  3 files changed, 7 insertions(+), 26 deletions(-)
> > 
...
> > diff --git a/drivers/pwm/pwm-mxs.c b/drivers/pwm/pwm-mxs.c
> > index a06040ac3268..1e2db39def22 100644
> > --- a/drivers/pwm/pwm-mxs.c
> > +++ b/drivers/pwm/pwm-mxs.c
> > @@ -1,13 +1,5 @@
> > -/*
> > - * Copyright 2012 Freescale Semiconductor, Inc.
> > - *
> > - * The code contained herein is licensed under the GNU General Public
> > - * License. You may obtain a copy of the GNU General Public License
> > - * Version 2 or later at the following locations:
> > - *
> > - * http://www.opensource.org/licenses/gpl-license.html
> > - * http://www.gnu.org/copyleft/gpl.html
> > - */
> > +// SPDX-License-Identifier: GPL-2.0-only
> 
> The deleted text says "or later"

Ah, I stumbled over this too. The deleted text says:

    "The code contained herein is licensed under the GNU General Public
    License."

which in itself reads like "you can use any version of the GPL" (i.e.,
GPL-1.0-or-later). Later then the text says:

    "You may obtain a copy of the GNU General Public License
    Version 2 or later at the following locations:"

which in my opinion does not say anything about which version of the GPL
the code is licensed under.

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox