mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	Roland Hieber <rhi@pengutronix.de>
Cc: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH] pwm: Replace license and copyright boilerplate by SPDX identfiers
Date: Sat, 23 May 2020 17:00:32 +0200	[thread overview]
Message-ID: <20200523150032.5lopw2n3c7onpqxe@pengutronix.de> (raw)
In-Reply-To: <20200523141612.3xjmugzalvokwubv@pengutronix.de>

Hello Sascha, hello Roland,

On Sat, May 23, 2020 at 04:16:12PM +0200, Roland Hieber wrote:
> On Fri, May 22, 2020 at 03:17:59PM +0200, Uwe Kleine-König wrote:
> > Hello Roland,
> > 
> > On Fri, May 22, 2020 at 02:55:56PM +0200, Roland Hieber wrote:
> > > On Wed, May 20, 2020 at 02:10:47PM +0200, Ahmad Fatoum wrote:
> > > > On 5/19/20 6:52 PM, Uwe Kleine-König wrote:
> > > > > diff --git a/drivers/pwm/pwm-mxs.c b/drivers/pwm/pwm-mxs.c
> > > > > index a06040ac3268..1e2db39def22 100644
> > > > > --- a/drivers/pwm/pwm-mxs.c
> > > > > +++ b/drivers/pwm/pwm-mxs.c
> > > > > @@ -1,13 +1,5 @@
> > > > > -/*
> > > > > - * Copyright 2012 Freescale Semiconductor, Inc.
> > > > > - *
> > > > > - * The code contained herein is licensed under the GNU General Public
> > > > > - * License. You may obtain a copy of the GNU General Public License
> > > > > - * Version 2 or later at the following locations:
> > > > > - *
> > > > > - * http://www.opensource.org/licenses/gpl-license.html
> > > > > - * http://www.gnu.org/copyleft/gpl.html
> > > > > - */
> > > > > +// SPDX-License-Identifier: GPL-2.0-only
> > > > 
> > > > The deleted text says "or later"
> > > 
> > > Ah, I stumbled over this too. The deleted text says:
> > > 
> > >     "The code contained herein is licensed under the GNU General Public
> > >     License."
> > > 
> > > which in itself reads like "you can use any version of the GPL" (i.e.,
> > > GPL-1.0-or-later). Later then the text says:
> > > 
> > >     "You may obtain a copy of the GNU General Public License
> > >     Version 2 or later at the following locations:"
> > > 
> > > which in my opinion does not say anything about which version of the GPL
> > > the code is licensed under.
> > 
> > This seems to be a problem in the Freescale template. I think I pointed
> > that out once, but nothing changed.
> > 
> > For practical reasons I'd interpret that as "GPL-2.0-or-later".
> 
> Yeah, I guess that's alright.
> 
> Reviewed-by: Roland Hieber <rhi@pengutronix.de>

I assume this Reviewed-by: applies only if we squash

diff --git a/drivers/pwm/pwm-mxs.c b/drivers/pwm/pwm-mxs.c
index 1e2db39def22..08819b43bc1d 100644
--- a/drivers/pwm/pwm-mxs.c
+++ b/drivers/pwm/pwm-mxs.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0-only
+// SPDX-License-Identifier: GPL-2.0-or-later
 // SPDX-FileCopyrightText: 2012 Freescale Semiconductor, Inc.
 
 #include <common.h>

into the patch Sascha applied.

Sascha, can you care for this?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2020-05-23 15:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 16:52 Uwe Kleine-König
2020-05-20 12:09 ` Sascha Hauer
2020-05-20 12:10 ` Ahmad Fatoum
2020-05-20 13:59   ` Uwe Kleine-König
2020-05-20 14:59     ` Ahmad Fatoum
2020-05-20 17:11       ` Uwe Kleine-König
2020-05-20 17:16         ` Ahmad Fatoum
2020-05-22 12:55   ` Roland Hieber
2020-05-22 13:17     ` Uwe Kleine-König
2020-05-23 14:16       ` Roland Hieber
2020-05-23 15:00         ` Uwe Kleine-König [this message]
2020-05-23 15:04           ` Roland Hieber
2020-05-25  5:49           ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200523150032.5lopw2n3c7onpqxe@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=rhi@pengutronix.de \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox