From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] serial: stm: set linux_console_name
Date: Wed, 3 Jun 2020 08:18:11 +0200 [thread overview]
Message-ID: <20200603061811.GN11869@pengutronix.de> (raw)
In-Reply-To: <48c08116-532d-56b6-40f5-558507c71eed@pengutronix.de>
On Fri, May 29, 2020 at 03:57:30PM +0200, Ahmad Fatoum wrote:
> Hello Michael,
>
> On 5/29/20 2:51 PM, Michael Grzeschik wrote:
> > We set the linux_console_name so for this uart the
> > linux.bootargs.console will be properly set.
> >
> > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> > ---
> > drivers/serial/stm-serial.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/serial/stm-serial.c b/drivers/serial/stm-serial.c
> > index ea482415ce..a2c3dcf56e 100644
> > --- a/drivers/serial/stm-serial.c
> > +++ b/drivers/serial/stm-serial.c
> > @@ -159,6 +159,7 @@ static int stm_serial_probe(struct device_d *dev)
> > cdev->flush = stm_serial_flush;
> > cdev->setbrg = stm_serial_setbaudrate;
> > cdev->dev = dev;
> > + cdev->linux_console_name = "ttyAMA";
>
> Couldn't we just combine the two drivers? On a cursory look, only
> difference is how they're probed?
Yes, that sounds good. Until this is done I applied this patch.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-06-03 6:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 12:51 Michael Grzeschik
2020-05-29 13:57 ` Ahmad Fatoum
2020-06-03 6:18 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200603061811.GN11869@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox