From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fixup! blspec: Allow the "options" key to be given multiple times
Date: Wed, 3 Jun 2020 08:57:10 +0200 [thread overview]
Message-ID: <20200603065709.GP11869@pengutronix.de> (raw)
In-Reply-To: <20200602075725.3979-1-a.fatoum@pengutronix.de>
On Tue, Jun 02, 2020 at 09:57:25AM +0200, Ahmad Fatoum wrote:
> constness was erroneously cast away. Reinstate const safety.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> common/blspec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/common/blspec.c b/common/blspec.c
> index 3be26d0a7a14..9e1036c8342c 100644
> --- a/common/blspec.c
> +++ b/common/blspec.c
> @@ -301,7 +301,7 @@ static struct blspec_entry *blspec_entry_open(struct bootentries *bootentries,
> if (!strcmp(name, "options")) {
> /* If there was a previous "options" key given, prepend its value
> * (as per spec). */
> - char *prev_val = blspec_entry_var_get(entry, name);
> + const char *prev_val = blspec_entry_var_get(entry, name);
> if (prev_val) {
> char *opts = xasprintf("%s %s", prev_val, val);
> blspec_entry_var_set(entry, name, opts);
> --
> 2.27.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-06-03 6:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 7:57 Ahmad Fatoum
2020-06-03 6:57 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200603065709.GP11869@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox