From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgNYm-0002ih-Dg for barebox@lists.infradead.org; Wed, 03 Jun 2020 07:11:37 +0000 Date: Wed, 3 Jun 2020 09:11:34 +0200 From: Sascha Hauer Message-ID: <20200603071134.GQ11869@pengutronix.de> References: <20200602075757.4734-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200602075757.4734-1-a.fatoum@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/3] common: restart: number unnamed restart handlers To: Ahmad Fatoum Cc: barebox@lists.infradead.org On Tue, Jun 02, 2020 at 09:57:55AM +0200, Ahmad Fatoum wrote: > Follow-up commit allows referencing specific restart handler by name. > Restart handlers default to "default" as name when none is given. > Number them sequentially instead. > > Signed-off-by: Ahmad Fatoum > --- > common/restart.c | 4 +++- > include/restart.h | 1 - > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/common/restart.c b/common/restart.c > index b19ae54657c0..dd15c8d5c362 100644 > --- a/common/restart.c > +++ b/common/restart.c > @@ -19,6 +19,7 @@ > #include > > static LIST_HEAD(restart_handler_list); > +static unsigned resetidx; > > /** > * restart_handler_register() - register a handler for restarting the system > @@ -31,7 +32,7 @@ static LIST_HEAD(restart_handler_list); > int restart_handler_register(struct restart_handler *rst) > { > if (!rst->name) > - rst->name = RESTART_DEFAULT_NAME; > + rst->name = basprintf("reset%u", resetidx); With this most existing restart handlers get a unique name, but in the next patch you give most of them the same name. I am not sure where this is aiming at. With the next patch every restart handler has a name, so why is the name still optional? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox