From: Sascha Hauer <s.hauer@pengutronix.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v1] startup: allow to abort dryrun just before starting the OS
Date: Mon, 8 Jun 2020 07:06:57 +0200 [thread overview]
Message-ID: <20200608050657.GH11869@pengutronix.de> (raw)
In-Reply-To: <20200606051304.14547-1-o.rempel@pengutronix.de>
On Sat, Jun 06, 2020 at 07:13:04AM +0200, Oleksij Rempel wrote:
> The dryrun in this function is used two times:
> - with "Would run %s\n" and return
> - to store dryrun for later use
>
> The second one makes no sense since the first one will abort execution.
> Since it is needed for debugging any way, it is better to allow to abort
> later, just before starting the OS.
I think that we must abort before running the command, not afterwards.
Originally it was thought that the bootscripts only configure the setup
for a following bootm. Many bootscripts failed to do so and just
start something right away, for these we indeed have to abort before
running the command.
You are right, this makes the second if(dryrun) pointless of course.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-06-08 5:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-06 5:13 Oleksij Rempel
2020-06-08 5:06 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608050657.GH11869@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox