mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Clement Leger <cleger@kalray.eu>
To: Sascha Hauer <s.hauer@pengutronix.de>, barebox@lists.infradead.org
Cc: Clement Leger <cleger@kalray.eu>,
	Oleksij Rempel <linux@rempel-privat.de>
Subject: [PATCH v5 2/7] common: elf: use calloc instead of xzalloc
Date: Thu, 11 Jun 2020 10:02:02 +0200	[thread overview]
Message-ID: <20200611080207.6482-3-cleger@kalray.eu> (raw)
In-Reply-To: <20200611080207.6482-1-cleger@kalray.eu>

This failure can be handled grecefully, use standard calloc.

Signed-off-by: Clement Leger <cleger@kalray.eu>
---
 common/elf.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/common/elf.c b/common/elf.c
index 55f5bc645..0e92661e1 100644
--- a/common/elf.c
+++ b/common/elf.c
@@ -19,7 +19,10 @@ static int elf_request_region(struct elf_image *elf, resource_size_t start,
 	struct resource *r_new;
 	struct elf_section *r;
 
-	r = xzalloc(sizeof(*r));
+	r = calloc(1, sizeof(*r));
+	if (!r)
+		return -ENOMEM;
+
 	r_new = request_sdram_region("elf_section", start, size);
 	if (!r_new) {
 		pr_err("Failed to request region: %pa %pa\n", &start, &size);
-- 
2.17.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2020-06-11  8:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11  8:02 [PATCH v5 0/7] elf: add better bootm support Clement Leger
2020-06-11  8:02 ` [PATCH v5 1/7] common: elf: fix warning on 32 bits architectures Clement Leger
2020-06-11  8:02 ` Clement Leger [this message]
2020-06-11  8:02 ` [PATCH v5 3/7] common: elf: check number of elf program headers Clement Leger
2020-06-11  8:02 ` [PATCH v5 4/7] common: elf: load elf directly from file Clement Leger
2020-06-11  8:02 ` [PATCH v5 5/7] common: elf: add elf_open, elf_close and elf_load Clement Leger
2020-06-11  8:02 ` [PATCH v5 6/7] common: bootm: add support for elf file loading Clement Leger
2020-06-11  8:02 ` [PATCH v5 7/7] mips: lib: bootm: use bootm elf loading capabilities Clement Leger
2020-06-12  5:22 ` [PATCH v5 0/7] elf: add better bootm support Oleksij Rempel
2020-06-12  6:55   ` Clément Leger
2020-06-12  6:57     ` Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200611080207.6482-3-cleger@kalray.eu \
    --to=cleger@kalray.eu \
    --cc=barebox@lists.infradead.org \
    --cc=linux@rempel-privat.de \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox