mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: David Dgien <dgienda125@gmail.com>
To: barebox@lists.infradead.org
Cc: David Dgien <dgienda125@gmail.com>
Subject: [RFC PATCH 0/8] Module and ARM Module updates and fixes
Date: Tue, 16 Jun 2020 23:43:56 -0400	[thread overview]
Message-ID: <20200617034404.5904-1-dgienda125@gmail.com> (raw)

This series fixes various bugs and bit-rot issues with the module
loading code. It also ports a couple of modules features from the Linux
kernel: arch specific section fixups, and module PLTs for ARM modules,
to contain veneers for 'bl' instructions.

There are two things in this series I'm looking for feedback on:
Linux implements module_frob_arch_sections as a weak symbol for the
default case. I didn't see any other "weak" functions in barebox, so I
wasn't sure if using that was acceptable. Since the Kconfig
HAVE_MOD_ARCH_SPECIFIC already exists as part of the change, I just used
that to define a static inline default implementation, but using a weak
function would make that slightly cleaner.

And in the patch that added the init macros to module.h, I wasn't sure
if it would be okay to pollute init.h with the #ifndef MODULE
directives, so instead I just #undef'd all of the initcalls before
redefining them in module.h.  If it's okay to add the #ifndef MODULE to
init.h, that would be significantly cleaner than the current
implementation.

David Dgien (8):
  Makefile: Initialize and export KBUILD variables
  module: Add init macros to module.h
  module: Fix adding module to list after layout
  module: Fix module command registration
  module: Implement HAVE_MOD_ARCH_SPECIFIC
  arm: makefile: Fix compiler flag variable
  arm: elf: Add THM relocation types
  arm: module: Allow modules outside of bl range

 Makefile                      |  12 +-
 arch/arm/Kconfig              |  15 +++
 arch/arm/Makefile             |   6 +-
 arch/arm/cpu/Kconfig          |   1 +
 arch/arm/include/asm/elf.h    |   3 +
 arch/arm/include/asm/module.h |  44 ++++++-
 arch/arm/lib32/Makefile       |   1 +
 arch/arm/lib32/module-plts.c  | 229 ++++++++++++++++++++++++++++++++++
 arch/arm/lib32/module.c       |  14 +++
 arch/arm/lib32/module.lds     |   4 +
 common/Kconfig                |   8 ++
 common/module.c               |  60 +++++----
 include/asm-generic/module.h  |  49 ++++++++
 include/module.h              | 109 ++++++++++++++++
 14 files changed, 523 insertions(+), 32 deletions(-)
 create mode 100644 arch/arm/lib32/module-plts.c
 create mode 100644 arch/arm/lib32/module.lds
 create mode 100644 include/asm-generic/module.h

-- 
2.27.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2020-06-17  3:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-17  3:43 David Dgien [this message]
2020-06-17  3:43 ` [RFC PATCH 1/8] Makefile: Initialize and export KBUILD variables David Dgien
2020-06-17  3:43 ` [RFC PATCH 2/8] module: Add init macros to module.h David Dgien
2020-06-17  3:43 ` [RFC PATCH 3/8] module: Fix adding module to list after layout David Dgien
2020-06-17  3:44 ` [RFC PATCH 4/8] module: Fix module command registration David Dgien
2020-06-17  3:44 ` [RFC PATCH 5/8] module: Implement HAVE_MOD_ARCH_SPECIFIC David Dgien
2020-06-17  3:44 ` [RFC PATCH 6/8] arm: makefile: Fix compiler flag variable David Dgien
2020-06-17  3:44 ` [RFC PATCH 7/8] arm: elf: Add THM relocation types David Dgien
2020-06-17  3:44 ` [RFC PATCH 8/8] arm: module: Allow modules outside of bl range David Dgien
2020-06-17 13:52   ` Sascha Hauer
2020-06-17 13:45 ` [RFC PATCH 0/8] Module and ARM Module updates and fixes Sascha Hauer
2020-06-18  1:54   ` David Dgien
2020-06-18 13:10     ` Sascha Hauer
2020-06-22 17:52       ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617034404.5904-1-dgienda125@gmail.com \
    --to=dgienda125@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox