From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 1/2] fastboot: Use make_temp() to create temporary file
Date: Wed, 17 Jun 2020 07:11:05 +0200 [thread overview]
Message-ID: <20200617051106.24328-1-s.hauer@pengutronix.de> (raw)
make_temp() was created for this purpose, so use it.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
common/fastboot.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/common/fastboot.c b/common/fastboot.c
index 6f54e939e7..c32b0a0e77 100644
--- a/common/fastboot.c
+++ b/common/fastboot.c
@@ -176,7 +176,6 @@ int fastboot_generic_init(struct fastboot *fb, bool export_bbu)
int ret;
struct file_list_entry *fentry;
struct fb_variable *var;
- static int instance;
var = fb_addvar(fb, "version");
fb_setvar(var, "0.4");
@@ -187,7 +186,9 @@ int fastboot_generic_init(struct fastboot *fb, bool export_bbu)
fb_setvar(var, "%u", fastboot_max_download_size);
}
- fb->tempname = basprintf(".fastboot.%d.img", instance++);
+ fb->tempname = make_temp("fastboot");
+ if (!fb->tempname)
+ return -ENOMEM;
if (IS_ENABLED(CONFIG_BAREBOX_UPDATE) && export_bbu)
bbu_handlers_iterate(fastboot_add_bbu_variables, fb);
--
2.27.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2020-06-17 5:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 5:11 Sascha Hauer [this message]
2020-06-17 5:11 ` [PATCH 2/2] fastboot: Drop support for downloading to buffer Sascha Hauer
-- strict thread matches above, loose matches on Subject: below --
2020-06-15 6:08 [PATCH 1/2] fastboot: Use make_temp() to create temporary file Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617051106.24328-1-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox