mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: David Dgien <dgienda125@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC PATCH 0/8] Module and ARM Module updates and fixes
Date: Wed, 17 Jun 2020 15:45:38 +0200	[thread overview]
Message-ID: <20200617134538.GC11869@pengutronix.de> (raw)
In-Reply-To: <20200617034404.5904-1-dgienda125@gmail.com>

Hi David,

On Tue, Jun 16, 2020 at 11:43:56PM -0400, David Dgien wrote:
> This series fixes various bugs and bit-rot issues with the module
> loading code. It also ports a couple of modules features from the Linux
> kernel: arch specific section fixups, and module PLTs for ARM modules,
> to contain veneers for 'bl' instructions.
> 
> There are two things in this series I'm looking for feedback on:
> Linux implements module_frob_arch_sections as a weak symbol for the
> default case. I didn't see any other "weak" functions in barebox, so I
> wasn't sure if using that was acceptable.

For things that are really mutually exclusive like different
implementations on different architectures I think weak functions are
ok. They are not ok as a quick hack for hooking something into something
though.

> Since the Kconfig
> HAVE_MOD_ARCH_SPECIFIC already exists as part of the change, I just used
> that to define a static inline default implementation, but using a weak
> function would make that slightly cleaner.
> 
> And in the patch that added the init macros to module.h, I wasn't sure
> if it would be okay to pollute init.h with the #ifndef MODULE
> directives, so instead I just #undef'd all of the initcalls before
> redefining them in module.h.  If it's okay to add the #ifndef MODULE to
> init.h, that would be significantly cleaner than the current
> implementation.

I think it's ok to add #ifndef MODULE to init.h

Anyway, what do you need modules for? Do you have a good reason or is it
just for the fun of it?

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2020-06-17 13:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-17  3:43 David Dgien
2020-06-17  3:43 ` [RFC PATCH 1/8] Makefile: Initialize and export KBUILD variables David Dgien
2020-06-17  3:43 ` [RFC PATCH 2/8] module: Add init macros to module.h David Dgien
2020-06-17  3:43 ` [RFC PATCH 3/8] module: Fix adding module to list after layout David Dgien
2020-06-17  3:44 ` [RFC PATCH 4/8] module: Fix module command registration David Dgien
2020-06-17  3:44 ` [RFC PATCH 5/8] module: Implement HAVE_MOD_ARCH_SPECIFIC David Dgien
2020-06-17  3:44 ` [RFC PATCH 6/8] arm: makefile: Fix compiler flag variable David Dgien
2020-06-17  3:44 ` [RFC PATCH 7/8] arm: elf: Add THM relocation types David Dgien
2020-06-17  3:44 ` [RFC PATCH 8/8] arm: module: Allow modules outside of bl range David Dgien
2020-06-17 13:52   ` Sascha Hauer
2020-06-17 13:45 ` Sascha Hauer [this message]
2020-06-18  1:54   ` [RFC PATCH 0/8] Module and ARM Module updates and fixes David Dgien
2020-06-18 13:10     ` Sascha Hauer
2020-06-22 17:52       ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617134538.GC11869@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=dgienda125@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox