From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: rpi: dts: fix MMIO resources clash breaking boot
Date: Thu, 18 Jun 2020 16:42:12 +0200 [thread overview]
Message-ID: <20200618144212.GO11869@pengutronix.de> (raw)
In-Reply-To: <20200617145016.2919-1-a.fatoum@pengutronix.de>
On Wed, Jun 17, 2020 at 04:50:16PM +0200, Ahmad Fatoum wrote:
> The rpi3b device tree specifies 1G of RAM in the memory node, but maps
> the highest 16M of RAM's physical address range for peripheral use.
>
> When support for device tree probing was first added for the rpi3b
> in e8fab18835a1 ("ARM: rpi: switch to DT probe and multi-image build"),
> it had a memory { } node overriding the kernel node size with 0, so the
> size is computed later correctly.
>
> 1dc748b3b202 ("dts: update to v5.1-rc1") came and renamed the upstream
> memory { } node to memory@0. So instead of overriding the old, we
> now created a second dummy along with the broken node.
> barebox did only parse the dummy, so it continued to limp along.
>
> 8226f7f90973 ("of: base: parse all available memory nodes") started
> considering both nodes and rendered barebox v2020.05.0 unable to start
> up on the rpi3b because of the conflict between RAM range and peripherals
> like the bcm2835_mbox caused by parsing the broken memory node.
>
> At least one board also was broken for the same reason[1], so a more
> robust approach is in order. For nodes that lack a phandle, the
> &{/path} syntax can be used instead. This has the benefit that should
> the path disappear in future, a compile failure would result.
>
> [1] 0d26ce1c11a1 ("ARM: Phytec phyFLEX i.MX6: delete wrong memory node")
>
> Fixes: 1dc748b3b202 ("dts: update to v5.1-rc1")
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-06-18 14:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 14:50 Ahmad Fatoum
2020-06-18 14:42 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618144212.GO11869@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox