From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Cc: "Daniel Glöckner" <dg@emlix.com>
Subject: [PATCH 14/21] fastboot: Warn when cb_download is called with file still open
Date: Fri, 19 Jun 2020 09:44:20 +0200 [thread overview]
Message-ID: <20200619074427.17289-15-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20200619074427.17289-1-s.hauer@pengutronix.de>
Warn when we are about to open a new download file without having
closed the old one.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
common/fastboot.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/common/fastboot.c b/common/fastboot.c
index c800e89a65..7f5b8b6f03 100644
--- a/common/fastboot.c
+++ b/common/fastboot.c
@@ -337,6 +337,7 @@ int fastboot_handle_download_data(struct fastboot *fb, const void *buffer,
void fastboot_download_finished(struct fastboot *fb)
{
close(fb->download_fd);
+ fb->download_fd = 0;
printf("\n");
@@ -356,6 +357,11 @@ static void cb_download(struct fastboot *fb, const char *cmd)
init_progression_bar(fb->download_size);
+ if (fb->download_fd > 0) {
+ pr_err("%s called and %s is still opened\n", __func__, fb->tempname);
+ close(fb->download_fd);
+ }
+
fb->download_fd = open(fb->tempname, O_WRONLY | O_CREAT | O_TRUNC);
if (fb->download_fd < 0) {
fastboot_tx_print(fb, FASTBOOT_MSG_FAIL, "internal error");
--
2.27.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-06-19 7:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 7:44 [PATCH v5 00/21] Slices and fastboot over UDP Sascha Hauer
2020-06-19 7:44 ` [PATCH 01/21] Introduce slices Sascha Hauer
2020-06-19 7:44 ` [PATCH 02/21] Add workqueues Sascha Hauer
2020-06-19 7:44 ` [PATCH 03/21] ratp: Switch to workqueues Sascha Hauer
2020-06-19 7:44 ` [PATCH 04/21] net: Add a slice to struct eth_device Sascha Hauer
2020-06-19 7:44 ` [PATCH 05/21] net: mdiobus: Add slice Sascha Hauer
2020-06-19 7:44 ` [PATCH 06/21] usb: Add a slice to usb host controllers Sascha Hauer
2020-06-19 7:44 ` [PATCH 07/21] usbnet: Add slice Sascha Hauer
2020-06-19 7:44 ` [PATCH 08/21] net: Call net_poll() in a poller Sascha Hauer
2020-06-19 7:44 ` [PATCH 09/21] net: reply to ping requests Sascha Hauer
2020-06-19 7:44 ` [PATCH 10/21] usbnet: Be more friendly in the receive path Sascha Hauer
2020-06-19 7:44 ` [PATCH 11/21] defconfigs: update renamed fastboot options Sascha Hauer
2020-06-19 7:44 ` [PATCH 12/21] globalvar: Add helper for deprecated variable names Sascha Hauer
2020-06-19 7:44 ` [PATCH 13/21] fastboot: rename usbgadget.fastboot_* variables to fastboot.* Sascha Hauer
2020-06-19 7:44 ` Sascha Hauer [this message]
2020-06-19 7:44 ` [PATCH 15/21] fastboot: Add fastboot_abort() Sascha Hauer
2020-06-19 7:44 ` [PATCH 16/21] fastboot: init list head in common Sascha Hauer
2020-06-19 7:44 ` [PATCH 17/21] fastboot net: implement fastboot over UDP Sascha Hauer
2020-06-29 19:50 ` Daniel Glöckner
2020-07-11 4:48 ` Sascha Hauer
2020-08-13 10:38 ` Sascha Hauer
2020-06-19 7:44 ` [PATCH 18/21] usb: fastboot: execute commands in command context Sascha Hauer
2020-06-19 7:44 ` [PATCH 19/21] Add WARN_ONCE() macro Sascha Hauer
2020-06-19 7:44 ` [PATCH 20/21] fs: Warn when filesystem operations are called from a poller Sascha Hauer
2020-06-19 7:44 ` [PATCH 21/21] Documentation: Add document for parallel execution in barebox Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619074427.17289-15-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=dg@emlix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox