From: Sascha Hauer <s.hauer@pengutronix.de>
To: Robert Karszniewicz <r.karszniewicz@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC PATCH 0/4] Introduce global.bootm.root env var for booting via PARTUUID
Date: Thu, 9 Jul 2020 16:14:00 +0200 [thread overview]
Message-ID: <20200709141400.GC15485@pengutronix.de> (raw)
In-Reply-To: <1593524914-228154-1-git-send-email-r.karszniewicz@phytec.de>
On Tue, Jun 30, 2020 at 03:48:30PM +0200, Robert Karszniewicz wrote:
> This patch introduces a new env var which specifies which device
> is the rootfs device to be used in Linux, passed to Linux via bootargs,
> identified by the rootfs partition's PARTUUID.
>
> global.bootm.root supplements global.bootm.appendroot, in that it overrides
> appendroot's naïve default, which picks the partition that the kernel resides
> on (global.bootm.image).
>
> I don't know if it is the right way, or a good way, but this is the shortest
> and simplest way that I've found.
>
> What do you think of this? And is it generally something that would be
> accepted, or is this out of scope for barebox?
>
> Example:
> detect mmc2
> global.bootm.image='/mnt/mmc2.0/zImage'
> global.bootm.appendroot=1
> global.bootm.root='/mnt/mmc2.1/'
Why do you pass the standard mount path here? I would expect /dev/mmc2.1.
In 4/4 you mount the root device. I think this should be avoided as it
only works when barebox has support for the rootfs, i.e. it doesn't work
for XFS or the like.
Ok, fsdev_set_linux_rootarg() is tied to a filesystem, so maybe we need
something similar for a cdev.
Generally I think barebox should support this usecase, but I am not
convinced the approach you took is the right API.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-07-09 14:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 13:48 Robert Karszniewicz
2020-06-30 13:48 ` [RFC PATCH 1/4] bootm: add env var root_dev Robert Karszniewicz
2020-06-30 13:48 ` [RFC PATCH 2/4] globalvar: add bootm.root Robert Karszniewicz
2020-06-30 13:48 ` [RFC PATCH 3/4] bootm: handle global.bootm.root Robert Karszniewicz
2020-06-30 13:48 ` [RFC PATCH 4/4] bootm: mount root device before accessing linux_rootarg Robert Karszniewicz
2020-06-30 14:20 ` [RFC PATCH 0/4] Introduce global.bootm.root env var for booting via PARTUUID Robert Karszniewicz
2020-07-01 5:58 ` Sascha Hauer
2020-07-08 6:55 ` Stefan Riedmüller
2020-07-09 14:14 ` Sascha Hauer [this message]
2020-07-13 11:18 ` Robert Karszniewicz
2020-07-14 18:37 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709141400.GC15485@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=r.karszniewicz@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox