From: Sascha Hauer <s.hauer@pengutronix.de>
To: Christian Mauderer <christian.mauderer@embedded-brains.de>
Cc: barebox@lists.infradead.org, a.fatoum@pengutronix.de
Subject: Re: [PATCH v4] FIT: Parse `load` and `entry` addresses.
Date: Tue, 14 Jul 2020 20:09:49 +0200 [thread overview]
Message-ID: <20200714180949.GS15485@pengutronix.de> (raw)
In-Reply-To: <20200714091139.26244-1-christian.mauderer@embedded-brains.de>
Hi Christian,
On Tue, Jul 14, 2020 at 11:11:39AM +0200, Christian Mauderer wrote:
> @@ -622,7 +622,8 @@ int bootm_boot(struct bootm_data *bootm_data)
> }
>
> ret = fit_open_image(data->os_fit, data->fit_config, "kernel",
> - &data->fit_kernel, &data->fit_kernel_size);
> + &data->fit_kernel, &data->fit_kernel_size,
> + &data->os_address, &data->os_entry);
bootm has -a and -e options to specify the load address and the entry
point. If given, these should take precedence over the addresses given
in the FIT image.
> int fit_open_image(struct fit_handle *handle, void *configuration,
> const char *name, const void **outdata,
> - unsigned long *outsize)
> + unsigned long *outsize, unsigned long *load,
> + unsigned long *entry)
> {
fit_open_image() has many parameters already and the two new ones are
not always needed or used. I think it's better to make getting the
addresses a separate function, fit_get_load_address() and
fit_get_entry() maybe?
Regards,
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-07-14 18:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 9:11 Christian Mauderer
2020-07-14 9:15 ` Ahmad Fatoum
2020-07-14 9:15 ` Christian Mauderer
2020-07-14 18:09 ` Sascha Hauer [this message]
2020-07-15 9:30 ` Christian Mauderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714180949.GS15485@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=christian.mauderer@embedded-brains.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox