[PATCH] arm: baltos: add environment node

[PATCH] arm: baltos: add environment node

[yegorslists]

From: Yegor Yefremov <yegorslists@googlemail.com>

Use the second SPL partition in NAND for environment storage.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 arch/arm/dts/am335x-baltos-minimal.dts | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/arm/dts/am335x-baltos-minimal.dts b/arch/arm/dts/am335x-baltos-minimal.dts
index 137c177b2..8dfad3eb0 100644
--- a/arch/arm/dts/am335x-baltos-minimal.dts
+++ b/arch/arm/dts/am335x-baltos-minimal.dts
@@ -22,6 +22,11 @@
 
 	chosen {
 		stdout-path = &uart0;
+
+		environment-nand {
+			compatible = "barebox,environment";
+			device-path = &nand, "partname:SPL.backup1";
+		};
 	};
 
 	cpus {
@@ -179,7 +184,7 @@
 	ranges = <0 0 0x08000000 0x10000000>;	/* CS0: NAND */
 	status = "okay";
 
-	nand@0,0 {
+	nand: nand@0,0 {
 		reg = <0 0 0>; /* CS0, offset 0 */
 		nand-bus-width = <8>;
 		ti,nand-ecc-opt = "bch8";
-- 
2.17.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] arm: baltos: add environment node

[Sascha Hauer]

Hi Yegor,

On Tue, Jul 14, 2020 at 07:13:28AM +0200, yegorslists@googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> Use the second SPL partition in NAND for environment storage.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  arch/arm/dts/am335x-baltos-minimal.dts | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/am335x-baltos-minimal.dts b/arch/arm/dts/am335x-baltos-minimal.dts
> index 137c177b2..8dfad3eb0 100644
> --- a/arch/arm/dts/am335x-baltos-minimal.dts
> +++ b/arch/arm/dts/am335x-baltos-minimal.dts
> @@ -22,6 +22,11 @@
>  
>  	chosen {
>  		stdout-path = &uart0;
> +
> +		environment-nand {
> +			compatible = "barebox,environment";
> +			device-path = &nand, "partname:SPL.backup1";
> +		};

Please add a phandle to the partition directly rather than to the NAND
device containing it.

When this is used as environment partition, shouldn't it be renamed
accordingly? In case the ROM needs one of the SPL backups, does it cope
with the environment being in SPL.backup1? Otherwise I would suggest
using SPL.backup3 for the environment.

Regards,
  Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox