mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Oleksij Rempel <o.rempel@pengutronix.de>, david@protonic.nl
Subject: [PATCH v3 1/3] devinfo: do not dump the device node for the root node
Date: Thu, 16 Jul 2020 08:46:40 +0200	[thread overview]
Message-ID: <20200716064642.25729-2-o.rempel@pengutronix.de> (raw)
In-Reply-To: <20200716064642.25729-1-o.rempel@pengutronix.de>

Calling the devinfo against a device which is linked to some devicetree
node weill result a devictree dump of this node. For example:

barebox@Protonic PRTI6Q board:/ devinfo sound-spdif.of
Bus: platform
Device node: /sound-spdif
sound-spdif {
        compatible = "fsl,imx-audio-spdif";
        model = "imx-spdif";
        spdif-controller = <0x7a>;
        spdif-in;
        spdif-out;
};

Calling same command on a device wich is linked to the root node of
devicetree, for example "machine.of", will trigger a dump fo complete
devicetree. Since the same functionality is provided by the "of_dump"
command, it is better to limit devinfo on the root device. After this
patch we would get following output:

barebox@Protonic PRTI6Q board:/ devinfo machine.of
Driver: board-protonic-imx6
Bus: platform
Parameters:
  boardid: 0 (type: uint32)
  boardrev: 1 (type: uint32)

In this example, "boardid" and "boardrev" are variabled provided by this
this specific board driver.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 commands/devinfo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/commands/devinfo.c b/commands/devinfo.c
index 81956b1cc0..018a7c4167 100644
--- a/commands/devinfo.c
+++ b/commands/devinfo.c
@@ -99,7 +99,7 @@ static int do_devinfo(int argc, char *argv[])
 			printf("\n");
 		}
 #ifdef CONFIG_OFDEVICE
-		if (dev->device_node) {
+		if (dev->device_node && dev->device_node != of_get_root_node()) {
 			printf("Device node: %s\n", dev->device_node->full_name);
 			of_print_nodes(dev->device_node, 0);
 		}
-- 
2.27.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2020-07-16  6:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16  6:46 [PATCH v2 0/3] introduce board-driver support Oleksij Rempel
2020-07-16  6:46 ` Oleksij Rempel [this message]
2020-07-16  9:40   ` [PATCH v3 1/3] devinfo: do not dump the device node for the root node Lucas Stach
2020-07-17  4:11     ` Oleksij Rempel
2020-07-16  6:46 ` [PATCH v3 2/3] of: base: register DT root as device Oleksij Rempel
2020-07-16  6:46 ` [PATCH v3 3/3] ARM: embest-riotboard: port board file to the driver model Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200716064642.25729-2-o.rempel@pengutronix.de \
    --to=o.rempel@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=david@protonic.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox