mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org, david@protonic.nl
Subject: Re: [PATCH v1 08/11] gpiolib: add gpio_array_to_id helper to get ID out of GPIO array
Date: Tue, 4 Aug 2020 07:22:37 +0200	[thread overview]
Message-ID: <20200804052237.aihruhckhmglinjd@pengutronix.de> (raw)
In-Reply-To: <20200803202222.GJ31536@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 2267 bytes --]

Hi Sascha,

On Mon, Aug 03, 2020 at 10:22:22PM +0200, Sascha Hauer wrote:
> Hi Oleksij,
> 
> On Thu, Jul 23, 2020 at 12:33:23PM +0200, Oleksij Rempel wrote:
> > Some boards provide a board version and/or ID coded by pull-up/down
> > resistors connected to the gpio pins (or pins which can be multiplexed
> > at some point as gpio). In this case every one implements own gpio id
> > reader function.
> > 
> > To avoid it, provide the common helper function to extract a value out
> > of provided gpio array.
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> >  drivers/gpio/gpiolib.c | 28 ++++++++++++++++++++++++++++
> >  include/gpio.h         |  5 +++++
> >  2 files changed, 33 insertions(+)
> > 
> > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> > index 27674af54c..2e9150d2ea 100644
> > --- a/drivers/gpio/gpiolib.c
> > +++ b/drivers/gpio/gpiolib.c
> > @@ -381,6 +381,34 @@ void gpio_free_array(const struct gpio *array, size_t num)
> >  }
> >  EXPORT_SYMBOL_GPL(gpio_free_array);
> >  
> > +int gpio_array_to_id(const struct gpio *array, size_t num, u32 *val)
> > +{
> > +	u32 id = 0;
> > +	int ret, i;
> > +
> > +	if (num > 32)
> > +		return -EOVERFLOW;
> > +
> > +	ret = gpio_request_array(array, num);
> > +	if (ret)
> > +		return ret;
> 
> This function expects an unrequested array and returns with the array
> requested. This is at least inconsistent.

fixed

> > +
> > +	/* Wait untill logic level will be stable */
> 
> s/untill/until/

fixed

> > +	udelay(5);
> 
> This delay looks rather arbitrary. Is it really necessary?

The vendor reported that otherwise will not always read proper value.

> > +	for (i = 0; i < num; i++) {
> > +		ret = gpio_is_active(array[i].gpio);
> > +		if (ret < 0)
> > +			return ret;
> > +
> > +		id |= ret << i;
> 
> 'ret' is signed. Does this work when i == 31 ?

yes, it works

Regards,
Oleksij

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2020-08-04  5:22 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23 10:33 [PATCH v1 00/11] prepare Protonic board code for mainline Oleksij Rempel
2020-07-23 10:33 ` [PATCH v1 01/11] ARM: dts: imx6q-prti6q: fix PHY register Oleksij Rempel
2020-07-23 10:33 ` [PATCH v1 02/11] of: base: register DT root as device Oleksij Rempel
2020-07-23 10:33 ` [PATCH v1 03/11] ARM: embest-riotboard: port board file to the driver model Oleksij Rempel
2020-07-23 10:33 ` [PATCH v1 04/11] net: port nvmem_get_mac_address() from linux kernel Oleksij Rempel
2020-07-23 10:33 ` [PATCH v1 05/11] of: of_net: sync of_get_mac_address() with latest kernel version Oleksij Rempel
2020-07-23 10:33 ` [PATCH v1 06/11] net: fec_imx: use of_get_mac_address() to get mac address out of DT Oleksij Rempel
2020-08-03 20:13   ` Sascha Hauer
2020-08-04  5:29     ` Oleksij Rempel
2020-07-23 10:33 ` [PATCH v1 07/11] of: of_device_get_match_compatible() helper Oleksij Rempel
2020-07-23 10:33 ` [PATCH v1 08/11] gpiolib: add gpio_array_to_id helper to get ID out of GPIO array Oleksij Rempel
2020-08-03 20:22   ` Sascha Hauer
2020-08-04  5:22     ` Oleksij Rempel [this message]
2020-07-23 10:33 ` [PATCH v1 09/11] ARM: protonic-imx6: port protonic specific board code Oleksij Rempel
2020-08-03 20:49   ` Sascha Hauer
2020-08-04  6:22     ` Oleksij Rempel
2020-07-23 10:33 ` [PATCH v1 10/11] of: add barebox-serial driver Oleksij Rempel
2020-07-23 10:33 ` [PATCH v1 11/11] ARM: dts: imx6q-prti6q: add barebox.serial node Oleksij Rempel
2020-08-03 21:12   ` Sascha Hauer
2020-08-04  5:48     ` Oleksij Rempel
2020-08-11  8:27       ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200804052237.aihruhckhmglinjd@pengutronix.de \
    --to=o.rempel@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=david@protonic.nl \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox