On Mon, Aug 03, 2020 at 10:13:14PM +0200, Sascha Hauer wrote: > On Thu, Jul 23, 2020 at 12:33:21PM +0200, Oleksij Rempel wrote: > > A mac address can be provided by the DT over nvmem cell. Start to use > > of_get_mac_address() since it will be able to read nvmem cell for us. > > > > Signed-off-by: Oleksij Rempel > > --- > > drivers/net/fec_imx.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/drivers/net/fec_imx.c b/drivers/net/fec_imx.c > > index 0c2d600d12..578a85c28b 100644 > > --- a/drivers/net/fec_imx.c > > +++ b/drivers/net/fec_imx.c > > @@ -628,6 +628,7 @@ static void fec_free_receive_packets(struct fec_priv *fec, int count, int size) > > static int fec_probe_dt(struct device_d *dev, struct fec_priv *fec) > > { > > struct device_node *mdiobus; > > + const char *mac_addr; > > int ret; > > > > ret = of_get_phy_mode(dev->device_node); > > @@ -640,6 +641,14 @@ static int fec_probe_dt(struct device_d *dev, struct fec_priv *fec) > > if (mdiobus) > > fec->miibus.dev.device_node = mdiobus; > > > > + mac_addr = of_get_mac_address(dev->device_node); > > + if (IS_ERR(mac_addr)) > > + return PTR_ERR(mac_addr); > > A MAC address *can* be provided by the DT, but it's not mandatory, no? > Shouldn't you return successfully here when no MAC adress is found? ok, fixed. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |