mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 2/3] fs: squashfs: Do not free root inode
Date: Mon, 10 Aug 2020 13:12:11 +0200	[thread overview]
Message-ID: <20200810111212.31286-3-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20200810111212.31286-1-s.hauer@pengutronix.de>

With inode reference counting in place the core will free the root
inode, so do not free it in the squashfs code.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 fs/squashfs/super.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/squashfs/super.c b/fs/squashfs/super.c
index e2b7b8d5a1..35df3a0307 100644
--- a/fs/squashfs/super.c
+++ b/fs/squashfs/super.c
@@ -83,7 +83,6 @@ void squashfs_put_super(struct super_block *sb)
 	}
 
 	if (sb->s_root) {
-		kfree(squashfs_i(sb->s_root->d_inode));
 		kfree(sb->s_root);
 		sb->s_root = NULL;
 	}
-- 
2.28.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2020-08-10 11:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-10 11:12 [PATCH 0/3] squashfs: Fix current master Sascha Hauer
2020-08-10 11:12 ` [PATCH 1/3] fs: squashfs: set s_op in time Sascha Hauer
2020-08-10 11:12 ` Sascha Hauer [this message]
2020-08-10 11:12 ` [PATCH 3/3] fs: Use iget_locked() rather than squashfs specific function Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200810111212.31286-3-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox