From: Jules Maselbas <jmaselbas@kalray.eu>
To: Barebox List <barebox@lists.infradead.org>
Cc: Jules Maselbas <jmaselbas@kalray.eu>,
Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH v4 08/13] usb: dwc2: host: Fix toggle reset
Date: Tue, 11 Aug 2020 17:16:32 +0200 [thread overview]
Message-ID: <20200811151637.17705-9-jmaselbas@kalray.eu> (raw)
In-Reply-To: <20200811151637.17705-1-jmaselbas@kalray.eu>
From USB 2.0 specification, section 9.4.5:
ClearFeature(ENDPOINT_HALT) request always results in
the data toggle being reinitialized to DATA0.
The hacky solution for now is to reset the toggle bit to DATA0 when
the host controller send a ClearFeature request on an endpoint.
Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
---
drivers/usb/dwc2/host.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/drivers/usb/dwc2/host.c b/drivers/usb/dwc2/host.c
index 8c116c5df..65fa95162 100644
--- a/drivers/usb/dwc2/host.c
+++ b/drivers/usb/dwc2/host.c
@@ -109,6 +109,14 @@ static void dwc2_hc_init(struct dwc2 *dwc2, uint8_t hc,
dwc2_writel(dwc2, 0, HCSPLT(hc));
}
+static void dwc2_endpoint_reset(struct dwc2 *dwc2, int in, int devnum, int ep)
+{
+ if (in)
+ dwc2->in_data_toggle[devnum][ep] = TSIZ_SC_MC_PID_DATA0;
+ else
+ dwc2->out_data_toggle[devnum][ep] = TSIZ_SC_MC_PID_DATA0;
+}
+
static int wait_for_chhltd(struct dwc2 *dwc2, u8 hc, uint32_t *sub, u8 *tgl)
{
int ret;
@@ -373,7 +381,18 @@ static int dwc2_submit_control_msg(struct usb_device *udev,
if (ret)
return ret;
+ if (setup->requesttype == USB_RECIP_ENDPOINT
+ && setup->request == USB_REQ_CLEAR_FEATURE) {
+ /* From USB 2.0, section 9.4.5:
+ * ClearFeature(ENDPOINT_HALT) request always results
+ * in the data toggle being reinitialized to DATA0.
+ */
+ int ep = le16_to_cpu(setup->index) & 0xf;
+ dwc2_endpoint_reset(dwc2, usb_pipein(pipe), devnum, ep);
+ }
+
udev->act_len = act_len;
+ udev->status = 0;
return 0;
}
--
2.17.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-08-11 15:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 15:16 [PATCH v4 00/13] usb: dwc2: Add host and gadget driver Jules Maselbas
2020-08-11 15:16 ` [PATCH v4 01/13] Revert "usb: Add dwc2 host driver" Jules Maselbas
2020-08-11 15:16 ` [PATCH v4 02/13] usb: dwc2: Add host controller driver Jules Maselbas
2020-08-14 6:21 ` Sascha Hauer
2020-08-14 8:15 ` Jules Maselbas
2020-08-14 13:12 ` Sascha Hauer
2020-08-11 15:16 ` [PATCH v4 03/13] usb: dwc2: host: Read dr_mode from device tree Jules Maselbas
2020-08-11 15:16 ` [PATCH v4 04/13] usb: dwc2: Rework roothub interface Jules Maselbas
2020-08-11 15:16 ` [PATCH v4 05/13] usb: dwc2: Rework timeout Jules Maselbas
2020-08-11 15:16 ` [PATCH v4 06/13] usb: dwc2: host: Handle dma mapping errors Jules Maselbas
2020-08-11 15:16 ` [PATCH v4 07/13] usb: dwc2: host: Dynamic fifo size support from Linux Jules Maselbas
2020-08-11 15:16 ` Jules Maselbas [this message]
2020-08-11 15:16 ` [PATCH v4 09/13] usb: dwc2: host: Rewrite dwc2_hc_init Jules Maselbas
2020-08-11 15:16 ` [PATCH v4 10/13] usb: dwc2: Add function to flush tx fifo Jules Maselbas
2020-08-11 15:16 ` [PATCH v4 11/13] usb: dwc2: Add structure for gadget driver Jules Maselbas
2020-08-11 15:16 ` [PATCH v4 12/13] usb: dwc2: Add " Jules Maselbas
2020-08-11 15:16 ` [PATCH v4 13/13] usb: dwc2: Use register_otg_device Jules Maselbas
2020-08-14 13:12 ` [PATCH v4 00/13] usb: dwc2: Add host and gadget driver Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200811151637.17705-9-jmaselbas@kalray.eu \
--to=jmaselbas@kalray.eu \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox