mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: barebox@lists.infradead.org, david@protonic.nl
Cc: Oleksij Rempel <o.rempel@pengutronix.de>
Subject: [PATCH v2] serial: imx: set CTS if DT property "linux, rs485-enabled-at-boot-time" is present
Date: Thu, 20 Aug 2020 09:30:39 +0200	[thread overview]
Message-ID: <20200820073039.3042-1-o.rempel@pengutronix.de> (raw)

If we have a "linux,rs485-enabled-at-boot-time" DT property, we should
set CTS flag as soon as possible to the active state. This will set an
RS485 transmitter to receive-enable mode. Otherwise the RS485 bus will
be blocked for entire system boot time and other bus participants will
not be able to communicate.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 drivers/serial/serial_imx.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/serial/serial_imx.c b/drivers/serial/serial_imx.c
index c0265fc2d7..056fa14c2a 100644
--- a/drivers/serial/serial_imx.c
+++ b/drivers/serial/serial_imx.c
@@ -60,6 +60,7 @@ struct imx_serial_priv {
 	void __iomem *regs;
 	struct clk *clk;
 	struct imx_serial_devtype_data *devtype;
+	bool rs485_mode;
 };
 
 static int imx_serial_reffreq(struct imx_serial_priv *priv)
@@ -107,6 +108,9 @@ static int imx_serial_init_port(struct console_device *cdev)
 
 	/* Enable FIFOs */
 	val = readl(regs + UCR2);
+	/* set CTS to not block RS485 bus */
+	if (priv->rs485_mode)
+		val |= UCR2_CTS;
 	val |= UCR2_SRST | UCR2_RXEN | UCR2_TXEN;
 	writel(val, regs + UCR2);
 
@@ -252,6 +256,10 @@ static int imx_serial_probe(struct device_d *dev)
 	if (of_property_read_bool(dev->device_node, "fsl,dte-mode"))
 		priv->dte_mode = 1;
 
+	if (of_property_read_bool(dev->device_node, "linux,rs485-enabled-at-boot-time") &&
+	    !of_property_read_bool(dev->device_node, "rs485-rts-active-low"))
+		priv->rs485_mode = 1;
+
 	imx_serial_init_port(cdev);
 
 	/* Enable UART */
-- 
2.28.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2020-08-20  7:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20  7:30 Oleksij Rempel [this message]
2020-08-24  7:03 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200820073039.3042-1-o.rempel@pengutronix.de \
    --to=o.rempel@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=david@protonic.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox