* [PATCH 1/2] mfd: stpmic1: warn if reset reason detection fails
@ 2020-09-03 10:24 Ahmad Fatoum
2020-09-03 10:24 ` [PATCH 2/2] ARM: stm32mp: enable mmc_extcsd in defconfig Ahmad Fatoum
2020-09-14 10:09 ` [PATCH 1/2] mfd: stpmic1: warn if reset reason detection fails Sascha Hauer
0 siblings, 2 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2020-09-03 10:24 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
stpmic1_set_reset_reason returns an error code, but so far we didn't
check it. Fix this.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
drivers/watchdog/stpmic1_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/stpmic1_wdt.c b/drivers/watchdog/stpmic1_wdt.c
index 458c5c16a3ff..12280f144762 100644
--- a/drivers/watchdog/stpmic1_wdt.c
+++ b/drivers/watchdog/stpmic1_wdt.c
@@ -200,7 +200,7 @@ static int stpmic1_wdt_probe(struct device_d *dev)
if (ret)
dev_warn(dev, "Cannot register poweroff handler\n");
- stpmic1_set_reset_reason(wdt->regmap);
+ ret = stpmic1_set_reset_reason(wdt->regmap);
if (ret)
dev_warn(dev, "Cannot query reset reason\n");
--
2.28.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/2] ARM: stm32mp: enable mmc_extcsd in defconfig
2020-09-03 10:24 [PATCH 1/2] mfd: stpmic1: warn if reset reason detection fails Ahmad Fatoum
@ 2020-09-03 10:24 ` Ahmad Fatoum
2020-09-14 10:09 ` [PATCH 1/2] mfd: stpmic1: warn if reset reason detection fails Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2020-09-03 10:24 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
The documentation suggests use of mmc_extcsd for configuring the boot
ack bit needed to boot from eMMC, thus have it enabled in the defconfig.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
arch/arm/configs/stm32mp_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/stm32mp_defconfig b/arch/arm/configs/stm32mp_defconfig
index c98908debc2a..92bdf5b04083 100644
--- a/arch/arm/configs/stm32mp_defconfig
+++ b/arch/arm/configs/stm32mp_defconfig
@@ -37,6 +37,7 @@ CONFIG_CMD_MEMINFO=y
CONFIG_CMD_ARM_MMUINFO=y
CONFIG_CMD_REGULATOR=y
CONFIG_CMD_MMC=y
+CONFIG_CMD_MMC_EXTCSD=y
# CONFIG_CMD_BOOTU is not set
CONFIG_CMD_GO=y
CONFIG_CMD_RESET=y
--
2.28.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] mfd: stpmic1: warn if reset reason detection fails
2020-09-03 10:24 [PATCH 1/2] mfd: stpmic1: warn if reset reason detection fails Ahmad Fatoum
2020-09-03 10:24 ` [PATCH 2/2] ARM: stm32mp: enable mmc_extcsd in defconfig Ahmad Fatoum
@ 2020-09-14 10:09 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2020-09-14 10:09 UTC (permalink / raw)
To: Ahmad Fatoum; +Cc: barebox
On Thu, Sep 03, 2020 at 12:24:43PM +0200, Ahmad Fatoum wrote:
> stpmic1_set_reset_reason returns an error code, but so far we didn't
> check it. Fix this.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/watchdog/stpmic1_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-14 10:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-03 10:24 [PATCH 1/2] mfd: stpmic1: warn if reset reason detection fails Ahmad Fatoum
2020-09-03 10:24 ` [PATCH 2/2] ARM: stm32mp: enable mmc_extcsd in defconfig Ahmad Fatoum
2020-09-14 10:09 ` [PATCH 1/2] mfd: stpmic1: warn if reset reason detection fails Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox