mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Hubert Feurstein <h.feurstein@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] imd: imd_calculate_crc32: initialize imd_crc to NULL
Date: Mon, 14 Sep 2020 12:21:04 +0200	[thread overview]
Message-ID: <20200914102104.GQ4498@pengutronix.de> (raw)
In-Reply-To: <CAFfN3gXFSC8AzwM2FdUb7kOr_Qp_scAxzWu47MkAEhBp4ePdrw@mail.gmail.com>

Hi Hubert,

On Fri, Sep 04, 2020 at 02:49:15PM +0200, Hubert Feurstein wrote:
> Am Fr., 4. Sept. 2020 um 12:10 Uhr schrieb Hubert Feurstein
> <h.feurstein@gmail.com>:
> > This fixes a NULL pointer dereference in the caller when imd-crc-token is
> > not found.
> In fact, it is even worse, it is a "uninitialized pointer dereference".

Applied to master, thanks. I reworded the commit to:

This fixes a dereference of an uninitialized pointer when imd-crc-token
is not found.

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2020-09-14 10:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-04 10:10 Hubert Feurstein
2020-09-04 12:49 ` Hubert Feurstein
2020-09-14 10:21   ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200914102104.GQ4498@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=h.feurstein@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox