mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Yann Sionneau <ysionneau@kalray.eu>
To: barebox@lists.infradead.org
Cc: Yann Sionneau <ysionneau@kalray.eu>
Subject: [PATCH] mci: fix wrong sd/mmc/emmc card size computation for arch where char is signed
Date: Mon, 14 Sep 2020 18:02:08 +0200	[thread overview]
Message-ID: <20200914160208.14747-1-ysionneau@kalray.eu> (raw)

char type can be either signed or unsigned according to C standard.
If your arch has signed char, this kind of computation will end up wrong
because of sign extension:

https://git.pengutronix.de/cgit/barebox/tree/drivers/mci/mci-core.c#n869

mci->capacity = mci->ext_csd[EXT_CSD_SEC_COUNT] << 0 |
		mci->ext_csd[EXT_CSD_SEC_COUNT + 1] << 8 |
		mci->ext_csd[EXT_CSD_SEC_COUNT + 2] << 16 |
		mci->ext_csd[EXT_CSD_SEC_COUNT + 3] << 24;

Turning the ext_csd field into u8 * fixes the issue.

Signed-off-by: Yann Sionneau <ysionneau@kalray.eu>
---
 include/mci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/mci.h b/include/mci.h
index 96547fb39..f6d845440 100644
--- a/include/mci.h
+++ b/include/mci.h
@@ -456,7 +456,7 @@ struct mci {
 	uint64_t capacity;	/**< Card's data capacity in bytes */
 	int ready_for_use;	/** true if already probed */
 	int dsr_imp;		/**< DSR implementation state from CSD */
-	char *ext_csd;
+	u8 *ext_csd;
 	int probe;
 	struct param_d *param_boot;
 	int bootpart;
-- 
2.17.1



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2020-09-14 16:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-14 16:02 Yann Sionneau [this message]
2020-09-15  7:33 ` Sascha Hauer
  -- strict thread matches above, loose matches on Subject: below --
2020-09-14 15:27 Yann Sionneau
2020-09-14 15:51 ` Ahmad Fatoum
2020-09-14 16:03   ` Yann Sionneau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200914160208.14747-1-ysionneau@kalray.eu \
    --to=ysionneau@kalray.eu \
    --cc=4a5bc850-9785-0db5-350a-7ae6d5b22cd6@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox